Review TYPO3_4-4 Abandoned

1242[FEATURE]: Show correct error message when uploading extension to TER and SOAP module is not installed.

Boris Gulay CR 0 V 0 Easy +22 −4 updated 06/03/13, 20:49

Commit message

and SOAP module is not installed.

If you try to upload extension to TER with SOAP module not installed you
receive unrelated error TX_TER_ERROR_GENERAL_EXTENSIONCONTAINSNOFILES.
After applying this changeset user will see correct message saying that
one of the supported SOAP modules should be installed.

* I've changed (-1) to defined constant.
* Code rewitten to fit CGL. Strict comparision in now used in condition
above, so I leave in non-strict.
* Branch is correct. Please, check master youself. ExtManager is totally
rewritten in it.

Review

  • Code review CR 0
  • Verified V 0

Files 4

Review log 9

  1. Björn Pedersen commented on patch set 1 04/04/11, 08:55

    I would prefer that you didn't submit this Generally a good idea. But needs some CGL cleanup.

    class.em_index.php:5853

    I would prefer normal CGL style: var first, strict comparison and a constant.

    class.em_soap.php:122

    Alternative world be to throw an exception if not client can be created.

    class.em_terconnection.php:318

    A constant would be better here.
  2. Steffen Kamper commented on patch set 1 04/04/11, 08:55

    wrong branch! Please commit the change to master after correcting the CGL issues.
  3. Steffen Kamper commented on patch set 1 04/04/11, 08:55

    Do not submit
  4. Boris Gulay uploaded patch set 2 04/04/11, 08:55

  5. Steffen Kamper commented on patch set 3 04/04/11, 08:55

    @Boris - you can't do that in this request. You have to abandon this and upload a new patch to refs/for/master. Features are only for master, never for other branches.
  6. Helmut Hummel commented on patch set 3 04/04/11, 08:55

    @Boris additionally, please abandon this change request. Thanks
  7. Helmut Hummel commented on patch set 3 04/04/11, 08:55

    @Boris: You have to amend the commit and remove the Change Id, in order to be able to submit the changes to refs/for/master
  8. Boris Gulay uploaded patch set 3 04/04/11, 08:55

  9. Boris Gulay commented on patch set 3 04/04/11, 08:55

    Abandoned Cannot be merged to 4.4