1242[FEATURE]: Show correct error message when uploading extension to TER and SOAP module is not installed.
Commit message
Review
-
Code review CR 0
-
Verified V 0
Files 4
Review log 9
-
Björn Pedersen commented on patch set 1 04/04/11, 08:55
I would prefer that you didn't submit this Generally a good idea. But needs some CGL cleanup.class.em_index.php:5853I would prefer normal CGL style: var first, strict comparison and a constant.class.em_soap.php:122Alternative world be to throw an exception if not client can be created.class.em_terconnection.php:318A constant would be better here. -
Steffen Kamper commented on patch set 1 04/04/11, 08:55
wrong branch! Please commit the change to master after correcting the CGL issues. -
Steffen Kamper commented on patch set 1 04/04/11, 08:55
Do not submit -
Boris Gulay uploaded patch set 2 04/04/11, 08:55
-
Steffen Kamper commented on patch set 3 04/04/11, 08:55
@Boris - you can't do that in this request. You have to abandon this and upload a new patch to refs/for/master. Features are only for master, never for other branches. -
Helmut Hummel commented on patch set 3 04/04/11, 08:55
@Boris additionally, please abandon this change request. Thanks -
Helmut Hummel commented on patch set 3 04/04/11, 08:55
@Boris: You have to amend the commit and remove the Change Id, in order to be able to submit the changes to refs/for/master -
Boris Gulay uploaded patch set 3 04/04/11, 08:55
-
Boris Gulay commented on patch set 3 04/04/11, 08:55
Abandoned Cannot be merged to 4.4