Review main Merged

12420[FEATURE] Improve the info popup

Stefan Galinski CR +2 V +2 Hard +357 −173 updated 06/03/13, 20:49

Commit message

The change improves the general spacing and CGL of the code,
removes some unused variables, tailores some very long lines
for better readability, adds the creation date, creation user
and last modified timestamp of the record and adds some general
actions to the references which improve the usability of the
feature a lot.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Susi Moog +1
  • Verified V +2
    • Christian Kuhn +2
    • Susi Moog +1

Issues 1

Files 2

Review log 7

  1. Susi Moog uploaded patch set 2 06/28/12, 18:36

  2. Susi Moog commented on patch set 2 06/28/12, 18:36

    Verified; Looks good to me, but someone else must approve fixed the comments and added some more CGL cleanup.
  3. Mr. Jenkins commented on patch set 1 06/28/12, 18:36

  4. Mr. Jenkins commented on patch set 2 06/28/12, 18:36

  5. Wouter Wolters commented on patch set 1 06/28/12, 18:36

    Verified; I would prefer that you didn't submit this See inline comments.

    show_item.php:336

    creationUserId and creationDate are not on the right place. Those need to be switched:)

    show_item.php:547

    integer
  6. Christian Kuhn commented on patch set 2 V 0 06/28/12, 18:36

    by team member; Looks good to me, approved Nice!
  7. Christian Kuhn merged patch set 2 06/28/12, 18:36