Review main Merged

1244[BUGFIX] Localization of child records fails when using MM type relations

Oliver Hader CR +2 V +2 Normal +107 −34 updated 06/03/13, 20:49

Commit message

Regular MM references are not localized, however if Inline Relational
Record Editing (IRRE) is used here, it would be the expected behaviour.

Unit tests are available in the irre_tutorial:
http://forge.typo3.org/projects/show/extension-irre_tutorial

Review

  • Code review CR +2
    • Andreas Wolf +2
    • Stefan Neufeind +1
    • Xavier Perseguers +1
  • Verified V +2
    • Andreas Wolf +2
    • Philipp Gampe +1

Issues 1

Files 1

Review log 43

Show 18 earlier messages
  1. Steffen Kamper commented on patch set 1 07/08/11, 20:16

    Looks good to me, but someone else must approve

    class.t3lib_tcemain.php:2691

    Olly, just a naming thingy: isOuterMost does not selfexplain what it is, the init of the var miss description and it looks strange that there is a function with same name too. As it's protected, could the var renamed to outerMostElement or simular, and the initialisation of the var with a description what's the meaning of?
  2. Francois Suter commented on patch set 2 07/08/11, 20:16

    Weird, I can't see the TCEmain changes in Gerrit...
  3. Francois Suter commented on patch set 2 07/08/11, 20:16

    I could see the changes by checking out the patch, but I realized I didn't have a proper setup to test, nor did I really understand what's going on in the code. Sorry.
  4. Oliver Hader uploaded patch set 2 07/08/11, 20:16

  5. Oliver Hader commented on patch set 3 07/08/11, 20:16

    The problems reported by Philipp have been fixed now...
  6. Oliver Hader uploaded patch set 3 07/08/11, 20:16

  7. Oliver Hader uploaded patch set 4 07/08/11, 20:16

  8. Oliver Hader commented on patch set 4 07/08/11, 20:16

    The problems reported by Philipp have been fixed now...
  9. Oliver Hader uploaded patch set 5 07/08/11, 20:16

  10. Oliver Hader uploaded patch set 6 07/08/11, 20:16

  11. Oliver Hader commented on patch set 6 V 0 07/08/11, 20:16

    by team member; Looks good to me, approved
  12. Oliver Hader commented on patch set 6 07/08/11, 20:16

    No score; No score
  13. Oliver Hader uploaded patch set 7 07/08/11, 20:16

  14. Stefan Neufeind commented on patch set 8 07/08/11, 20:16

    Looks good to me, but someone else must approve
  15. Stefan Neufeind commented on patch set 9 07/08/11, 20:16

    Looks good to me, but someone else must approve brief review only, but looks okay
  16. Oliver Hader uploaded patch set 9 07/08/11, 20:16

  17. Oliver Hader commented on patch set 9 07/08/11, 20:16

    No changes, just new upload to get rid of submodule dependencies
  18. Andreas Wolf commented on patch set 10 07/08/11, 20:16

    Any hints on how to run the unit tests? The fail with an "Attempt to localize record without permission" for me...
  1. Andreas Wolf commented on patch set 10 V 0 07/08/11, 20:16

    by team member; Looks good to me, approved
  2. Stefan Neufeind commented on patch set 10 07/08/11, 20:16

    Looks good to me, but someone else must approve brief review only, but looks okay
  3. Oliver Hader uploaded patch set 10 07/08/11, 20:16

  4. Oliver Hader commented on patch set 10 07/08/11, 20:16

    New changeset to get Jenkins happy...
  5. Xavier Perseguers uploaded patch set 8 07/08/11, 20:16

  6. Xavier Perseguers commented on patch set 8 07/08/11, 20:16

    Looks good to me, but someone else must approve New patch set to fix miss of DBAL submodule reference.
  7. Xavier Perseguers commented on patch set 10 07/08/11, 20:16

    Looks good to me, but someone else must approve
  8. Helmut Hummel commented on patch set 1 07/08/11, 20:16

    I would prefer that you didn't submit this $inlineSubType = 'mm' should be $inlineSubType == 'mm' see inline comment

    class.t3lib_tcemain.php:2691 Reply

    The isOuterMost() is already implemented, not introduced in this patch

    class.t3lib_tcemain.php:3760

    Just from reading, this looks weird: If it is not a NestedElementCall, the nestedElementCall is registered If the code is fine that way, would it make sense to rename the method to: isNestedElementCallRegistered() ?

    class.t3lib_tcemain.php:3960

    Shouldn't this read: $inlineSubType == 'mm' instead?
  9. Helmut Hummel commented on patch set 1 07/08/11, 20:16

    I would prefer that you didn't submit this accidentally removed my negative vote
  10. Helmut Hummel commented on patch set 1 2 comments 07/08/11, 20:16

    No score more comments
  11. Philipp Gampe commented on patch set 2 07/08/11, 20:16

    Well, the patch partly works... I can localize all children records at once. BUT: (in translated record:) After save, I can not expand the children elements any more. Sometimes both the translate records and the original records show up as children. The reference from Offers to Hotel always shows the original entry, not the translation. Unit tests from irre_tutorial are green after patch, but I get always mysql errors because database dummy_test does not exist on my server. Also with indexed_search installed, I get a fatal error.
  12. Philipp Gampe commented on patch set 6 07/08/11, 20:16

    merge fails after latest CGL changes ... maybe someone more knowledged can rebase it ?
  13. Philipp Gampe commented on patch set 8 V 0 07/08/11, 20:16

    Works for me :)
  14. Philipp Gampe commented on patch set 9 V 0 07/08/11, 20:16

    Renewing my vote. Mr. Jenkins complaines about workspaces. Unrelated to this patch.
  15. Philipp Gampe commented on patch set 10 V 0 07/08/11, 20:16

    -v +1 -r 0
  16. Philipp Gampe commented on patch set 10 07/08/11, 20:16

    heko
  17. Mr. Jenkins commented on patch set 3 07/08/11, 20:16

  18. Mr. Jenkins commented on patch set 4 07/08/11, 20:16

  19. Mr. Jenkins commented on patch set 5 07/08/11, 20:16

  20. Mr. Jenkins commented on patch set 6 07/08/11, 20:16

  21. Mr. Jenkins commented on patch set 7 07/08/11, 20:16

  22. Mr. Jenkins commented on patch set 8 07/08/11, 20:16

  23. Mr. Jenkins commented on patch set 9 07/08/11, 20:16

    Fails; I would prefer that you didn't submit this Build Failed http://ci.typo3.org/job/typo3-v4-core-gerrit/907/ : FAILURE
  24. Mr. Jenkins commented on patch set 10 07/08/11, 20:16

  25. Andreas Wolf merged patch set 10 07/08/11, 20:16