12442[BUGFIX] Bootstrap must check if submodules exist
Commit message
Review
-
Code review CR 0
-
Verified V 0
Files 1
Review log 21
-
Oliver Klee commented on patch set 1 06/30/12, 12:29
(4 inline comments)BaseSetup.php:47@var array is missing I'd also propose: submodules -> paths to GIT submodules I'd propose a rename: $pathsOfRequiredSubmodulesBaseSetup.php:222space after foreach missingBaseSetup.php:225break; (because one error is enough) ... or you could move the die in here so that we won't need the flag anymore.BaseSetup.php:231I'd prefer double quotes instead of the <em> because this message could also appear on the command line. -
Philipp Gampe commented on patch set 1 06/30/12, 12:29
(4 inline comments) The next version has the die moved inside the foreach loop and I renamed the property as suggested.BaseSetup.php:47ReplyDoneBaseSetup.php:222ReplyDoneBaseSetup.php:225ReplyDoneBaseSetup.php:231ReplyDone -
Oliver Klee commented on patch set 2 06/30/12, 12:29
(2 inline comments) Looks good. Just one PHPDoc issue and a naming issue. I'll update the patch in a minute. -
Oliver Klee uploaded patch set 3 06/30/12, 12:29
-
Oliver Klee commented on patch set 3 06/30/12, 12:29
Looks good to me, but someone else must approve -
Christian Kuhn commented on patch set 3 06/30/12, 12:29
I would prefer that you didn't submit this I think we shouldn't start checking for every problem that could possibly exist in bootstrap. This is code that is executed every single time typo3 is called, so it should only do things (especially when it comes to disk access) that is really needed. While it is true, that a developer could maybe forget to checkout the submodules (even if it is clearly mentioned in the wiki, maybe we could improve there), this code is for devs only, and we should expect them to come up with a working setup. The code is not needed for any user who works with the packages. Sry Phillip, I'm -1 for this change, I don't think we should check for a correct dev setup on every single request. -
Philipp Gampe uploaded patch set 2 06/30/12, 12:29
-
Philipp Gampe commented on patch set 3 06/30/12, 12:29
This are 12 filesystem calls which should get cached in the OS IO cache anyway. Compared to the huge number of calls that are done anyway to run such a big CMS like TYPO3, this is nothing. Anyway, I tried first to check only in the install tool, but this does not work, because the mentioned (see forge) error happens during inclusion of the ext_localconf.php files. As only extbase (and maybe) fluid are required submodules, we could reduce the list of required submodules. Thinking further, we could just check for extbase, because that is the one that is really required and if one is there, the others are most like there too. -
Philipp Gampe uploaded patch set 4 06/30/12, 12:29
-
Susi Moog commented on patch set 5 06/30/12, 12:29
Do not submit Sorry Philipp, but I don't want "dev specific" code in the TYPO3 core at all, especially not code that is located in the bootstrap and therefore executed every time. What would probably be an alternative: Let the install tool (and only that ;)) check if extbase and fluid exist - as they are required now, they should exist like typo3temp et al. So maybe we can introduce this check there. -
Philipp Gampe commented on patch set 5 06/30/12, 12:29
OK I run some tests. v4 took about 33s for one million calls. This is reduced to 7s with v5 while v5 spends 2/3 on user compared to 1/1 with v4. This are only 2 I/O calls left and compared to the other expansive checks above should not hurt much, makes sure that the env is set up properly. Actually we would need some kind of context to switch between more expansive checks and a super fast production bootstrap. -
Philipp Gampe uploaded patch set 5 06/30/12, 12:29
-
Philipp Gampe commented on patch set 5 06/30/12, 12:29
@Susanne, I tried that and it does not work, because TYPO3 crashes as soon as it tries to include the ext_localconf.php files from extensions. And the extbase core extensions contains calls to Tx_Extbase_Utility_Extension which will result in a fatal error that is completely misleading. Just try to remove typo3/sysext/extbase and see what happens. What I am really missing here is a context ;) -
Mr. Jenkins commented on patch set 1 06/30/12, 12:29
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/4632/ : SUCCESS -
Mr. Jenkins commented on patch set 2 06/30/12, 12:29
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/4633/ : SUCCESS -
Mr. Jenkins commented on patch set 3 06/30/12, 12:29
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/4635/ : SUCCESS -
Mr. Jenkins commented on patch set 4 06/30/12, 12:29
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/4642/ : SUCCESS -
Mr. Jenkins commented on patch set 5 06/30/12, 12:29
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/4644/ : SUCCESS -
Wouter Wolters commented on patch set 3 06/30/12, 12:29
I would prefer that you didn't submit this After some thinking I agree with Christian here. This checks are indeed for every TYPO3 request -
Wouter Wolters commented on patch set 3 06/30/12, 12:29
Looks good to me, but someone else must approve -
Philipp Gampe commented on patch set 5 06/30/12, 12:29
Abandoned Wait until bootstrap is further refactored (maybe contexts?).