Review TYPO3_4-5 Merged

1246[BUGFIX] Send header Error 404 in case of page not found errors

Steffen Gebert CR +2 V +2 Easy +15 −6 updated 06/03/13, 20:49

Commit message

If a page is not found, status 404 has to be sent.

Due to a recent change, an Exception is thrown instead of exiting.
As the Exception Handler overwrites the status 404 with a 503, this
code was sent to the client.

Review

  • Code review CR +2
    • Susi Moog +2
  • Verified V +2
    • Susi Moog +2

Issues 1

Files 1

Review log 10

  1. Steffen Kamper commented on patch set 1 03/31/11, 13:48

    Verified; Looks good to me, but someone else must approve
  2. Helmut Hummel commented on patch set 1 03/31/11, 13:48

    Looks good to me, but someone else must approve

    class.tslib_fe.php:1032

    please use exit() instead of exit();
  3. Peter Beernink commented on patch set 2 03/31/11, 13:48

    Verified; Looks good to me, but someone else must approve
  4. Steffen Gebert uploaded patch set 2 03/31/11, 13:48

  5. Susi Moog commented on patch set 3 V 0 03/31/11, 13:48

    by team member; Looks good to me, approved
  6. Steffen Gebert commented on patch set 3 03/31/11, 13:48

    rebased version
  7. Steffen Gebert uploaded patch set 3 03/31/11, 13:48

  8. Mr. Jenkins commented on patch set 2 03/31/11, 13:48

  9. Mr. Jenkins commented on patch set 3 03/31/11, 13:48

  10. Susi Moog merged patch set 3 03/31/11, 13:48