12504[TASK] Move buttons in user setting into advanced functions
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Georg Ringer +1
- Wouter Wolters +1
-
Verified V +2
- Christian Kuhn +2
- Georg Ringer +1
- Wouter Wolters +1
Issues 2
Files 3
Review log 13
-
Susi Moog uploaded patch set 2 07/29/12, 14:21
-
Susi Moog uploaded patch set 3 07/29/12, 14:21
-
Susi Moog commented on patch set 3 07/29/12, 14:21
Helmut mentioned that editors were able to reset their configuration before and should be able to do that after the patch, too, so I just moved the buttons to advanced. -
Christian Kuhn commented on patch set 3 V 0 07/29/12, 14:21
by team member; Looks good to me, approved -
Christian Kuhn commented on patch set 3 07/29/12, 14:21
(1 inline comment) -
Georg Ringer commented on patch set 3 07/29/12, 14:21
Verified; Looks good to me, but someone else must approveindex.php:606should we use a hsc() here? -
Felix Kopp commented on patch set 2 07/29/12, 14:21
Verified; Looks good to me, but someone else must approve Nice follow-up!!! Thank you -
Mr. Jenkins commented on patch set 1 07/29/12, 14:21
Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/4691/ : FAILURE -
Mr. Jenkins commented on patch set 2 07/29/12, 14:21
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/4693/ : SUCCESS -
Mr. Jenkins commented on patch set 3 07/29/12, 14:21
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/4696/ : SUCCESS -
Wouter Wolters commented on patch set 2 07/29/12, 14:21
Verified; Looks good to me, but someone else must approve -
Wouter Wolters commented on patch set 3 07/29/12, 14:21
Verified; Looks good to me, but someone else must approve -
Christian Kuhn merged patch set 3 07/29/12, 14:21