Review main Merged

12504[TASK] Move buttons in user setting into advanced functions

Susi Moog CR +2 V +2 Normal +46 −21 updated 06/03/13, 20:49

Commit message

The buttons "clear configuration" and "reset
temporary data" are advanced functions and should
therefore be moved to the advanced tab.

Additionally the buttons divert the attention, so that
it is very hard to notice the save button on the
top.

The patch moves the buttons to the advanced tab and
additionally aligns the select box(es) with the
input and button fields.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Georg Ringer +1
    • Wouter Wolters +1
  • Verified V +2
    • Christian Kuhn +2
    • Georg Ringer +1
    • Wouter Wolters +1

Issues 2

Files 3

Review log 13

  1. Susi Moog uploaded patch set 2 07/29/12, 14:21

  2. Susi Moog uploaded patch set 3 07/29/12, 14:21

  3. Susi Moog commented on patch set 3 07/29/12, 14:21

    Helmut mentioned that editors were able to reset their configuration before and should be able to do that after the patch, too, so I just moved the buttons to advanced.
  4. Christian Kuhn commented on patch set 3 V 0 07/29/12, 14:21

    by team member; Looks good to me, approved
  5. Christian Kuhn commented on patch set 3 07/29/12, 14:21

    (1 inline comment)
  6. Georg Ringer commented on patch set 3 07/29/12, 14:21

    Verified; Looks good to me, but someone else must approve

    index.php:606

    should we use a hsc() here?
  7. Felix Kopp commented on patch set 2 07/29/12, 14:21

    Verified; Looks good to me, but someone else must approve Nice follow-up!!! Thank you
  8. Mr. Jenkins commented on patch set 1 07/29/12, 14:21

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/4691/ : FAILURE
  9. Mr. Jenkins commented on patch set 2 07/29/12, 14:21

  10. Mr. Jenkins commented on patch set 3 07/29/12, 14:21

  11. Wouter Wolters commented on patch set 2 07/29/12, 14:21

    Verified; Looks good to me, but someone else must approve
  12. Wouter Wolters commented on patch set 3 07/29/12, 14:21

    Verified; Looks good to me, but someone else must approve
  13. Christian Kuhn merged patch set 3 07/29/12, 14:21