Review main Merged

1251[BUGFIX] TCA Tree should respect requestUpdate and type

Marco Huber CR +2 V +2 Easy +16 −1 updated 06/03/13, 20:49

Commit message

TCA Tree should respect $TCA['myTable']['ctrl']['requestUpdate']
and $TCA['myTable']['type'], but the onChange Javascript is missing.

Review

  • Code review CR +2
    • Steffen Ritter +2
    • Stefan Neufeind +1
    • Fabien Udriot +1
  • Verified V +2
    • Steffen Ritter +2
    • Thorsten Kahler +1

Issues 1

Files 1

Review log 29

Show 4 earlier messages
  1. Marco Huber uploaded patch set 2 07/08/11, 13:51

  2. Stefano Kowalke commented on patch set 3 07/08/11, 13:51

    I would prefer that you didn't submit this

    class.t3lib_tceforms_tree.php:68

    Please don't use global anymore in favor of $GLOBALS['TCA'].

    class.t3lib_tceforms_tree.php:156

    Use $GLOBALS['TCA'][$table]['ctrl']['type']
  3. Stefano Kowalke commented on patch set 3 07/08/11, 13:51

  4. Marco Huber uploaded patch set 3 07/08/11, 13:51

  1. Stefan Neufeind commented on patch set 4 07/08/11, 13:51

    looks okay apart from CGL-fixes imho
  2. Stefano Kowalke commented on patch set 4 07/08/11, 13:51

    Looks good to me, but someone else must approve
  3. Marco Huber uploaded patch set 4 07/08/11, 13:51

  4. Marco Huber commented on patch set 4 07/08/11, 13:51

    changed $TCA to $GLOBALS['TCA'] and removed "global $TCA;"
  5. Marco Huber commented on patch set 4 07/08/11, 13:51

    I answered Fabien's question on http://forge.typo3.org/issues/25382 "The field must be of type "select" and renderMode "tree" ("TCA tree" ;-)). If such a field is listed as requestUpdate-field the needed Javascript is missing."
  6. Steffen Gebert commented on patch set 5 07/08/11, 13:51

    Marco, that's a problem with the submodules being added. You're change is based on [FEATURE] Add a time field to the Date Picker of datetime fields, which probably before the change. You can get out of this by cherry-picking the commit and then do "git checkout HEAD -- typo3/sysext/". I will do this for you. Stay tuned - and don't surrender.. ;-)
  7. Thorsten Kahler commented on patch set 6 07/08/11, 13:51

    Fails The patch doesn't work for me. According to Steffen Ritter the "checkchange" listener inside the JS block (line 155) has to be extended to reload the form after calling "TYPO3.Components.Tree.TcaCheckChangeHandler".
  8. Thorsten Kahler commented on patch set 6 V 0 07/08/11, 13:51

    Ignore my last comment: I was irritated by Gerrit. The patch works for me.
  9. Stefan Neufeind commented on patch set 6 07/08/11, 13:51

    Looks good to me, but someone else must approve
  10. Steffen Gebert uploaded patch set 6 07/08/11, 13:51

  11. Steffen Ritter commented on patch set 6 07/08/11, 13:51

    Looks good to me, approved
  12. Steffen Ritter commented on patch set 6 V 0 07/08/11, 13:51

    by team member
  13. Marco Huber uploaded patch set 5 07/08/11, 13:51

  14. Marco Huber commented on patch set 5 07/08/11, 13:51

    Hopefully the indents are now correct. The CGLs says nothing about grouped if statements.
  15. Marco Huber commented on patch set 5 07/08/11, 13:51

    Wer kann mir sagen wass jetzt schon wieder nicht stimmt und wieso Mr. Jenkins den Patch nicht mag? Also wirklich, mit git und gerrit machts nicht wirklich Spaß.
  16. Fabien Udriot commented on patch set 4 07/08/11, 13:51

    Comment added on the ticket http://forge.typo3.org/issues/25382

    class.t3lib_tceforms_tree.php:153

    CGL: should have one more "tab" to indent comment

    class.t3lib_tceforms_tree.php:156

    CGL says: long condition in "if" statement should be indented as follows: if ($this->getSomeCodition($this->getSomeVariable()) && $this->getAnotherCondition()) { } Checkout manual: https://svn.typo3.org/TYPO3v4/Documentation/doc_core_cgl/trunk/doc_core_cgl/doc/doc_core_cgl.pdf
  17. Fabien Udriot commented on patch set 4 2 comments 07/08/11, 13:51

    I would prefer that you didn't submit this A few CGL improvement might be good. See comments.
  18. Fabien Udriot commented on patch set 6 07/08/11, 13:51

    Looks good to me, but someone else must approve
  19. Richard Schaufler commented on patch set 1 07/08/11, 13:51

    Verified; Looks good to me, but someone else must approve Works fine
  20. Mr. Jenkins commented on patch set 2 07/08/11, 13:51

    Fails; I would prefer that you didn't submit this Build Failed FAILURE: http://ci.typo3.org/job/typo3-v4-core-gerrit/257/
  21. Mr. Jenkins commented on patch set 3 07/08/11, 13:51

  22. Mr. Jenkins commented on patch set 4 07/08/11, 13:51

  23. Mr. Jenkins commented on patch set 5 07/08/11, 13:51

    Fails; I would prefer that you didn't submit this Build Failed http://ci.typo3.org/job/typo3-v4-core-gerrit/602/ : FAILURE
  24. Mr. Jenkins commented on patch set 6 07/08/11, 13:51

  25. Steffen Ritter merged patch set 6 07/08/11, 13:51