12566[TASK] Remove radio buttons from "new content elements" overview
Commit message
Review
-
Code review CR +2
- Georg Ringer +2
- Oliver Hader +1
-
Verified V +2
- Georg Ringer +2
- Oliver Hader +1
Files 1
Review log 24
-
Dmitry Dulepov commented on patch set 1 04/14/13, 13:02
Do not submit The change does not apply to the current master. It is no longer valid for 6.0 because such removal is a new feature. 6.1 is closed for new features, so this has to go to 6.2. -
Stefan Neufeind commented on patch set 1 04/14/13, 13:02
@Soren: Please discuss a resolution for this with some core-dev. As Philipp said, in general I like the change ... -
Stefan Neufeind commented on patch set 1 04/14/13, 13:02
If we can't make it work fully correct (due to BE-layouts etc.) I think I'm with Felix we should consider to remove that wizard. -
Benni Mack commented on patch set 1 04/14/13, 13:02
With 6.0, we dont have the option that the "new content element" wizard anymore to choose a position (colPos) in step 2, so the radio buttons are not needed anymore. I suggest we do this: * Remove every part of the new Content Element wizard (radioboxes, rendering below) that suggests to use the two-step-process * Remove old "non-tab" option and version completely, and deprecate the TSconfig options -
Susi Moog commented on patch set 1 04/14/13, 13:02
Looks good to me, but someone else must approve -
Georg Ringer commented on patch set 1 04/14/13, 13:02
it is not a feature, there is nothing new, it just removes something which was never needed -
Oliver Hader commented on patch set 2 04/14/13, 13:02
On Apr. 6th Benni as RM for 6.1 stated what he'd like to see in this regard - this change is thus part of that request (leaving out the TSconfig options). Therefore it's known and accepted. Besides that, it's not a feature and does remove components that are not used any more - thus, the behaviour has been changed already in 6.0. -
Oliver Hader commented on patch set 2 04/14/13, 13:02
Looks good to me, but someone else must approve -
Oliver Hader commented on patch set 2 04/14/13, 13:02
Fails The possibility to select the column is still there - so, this patch would break it - example, get to Web>List module, create a new element using the link in the doc-header, select the "wizard" there... still have the possibility to select the columns there -
Georg Ringer uploaded patch set 2 04/14/13, 13:02
-
Oliver Hader commented on patch set 3 04/14/13, 13:02
Verified; Looks good to me, but someone else must approve Thanks, looks good now. Removing Dmitry's blocking vote at this stage. -
Georg Ringer uploaded patch set 3 04/14/13, 13:02
-
Soren Malling commented on patch set 1 04/14/13, 13:02
Screenshot of that usecase? Can't really bend my head around where that occurs? -
Soren Malling commented on patch set 1 04/14/13, 13:02
Suggestion on how to handle this? Does that "columns list" respect backend_layout ? We could show the chosen content element above the columns? But what happens if you click a new content element? -
Philipp Gampe commented on patch set 1 04/14/13, 13:02
Verified; I would prefer that you didn't submit this I must veto this one because it makes adding content from list module very confusing. Previously, I could select the content element and then the click to column to add. Now I can still do that, but I do not see my first choice visually. IMHO this is a no-go. Actually I like the idea. Maybe switch the two choices around (that would be a bigger change) or add some kind of indicator to the selected item via CSS? -
Philipp Gampe commented on patch set 1 04/14/13, 13:02
Simple use the list module, click new content on top (docheader), select new content wizard, ... See issue: http://forge.typo3.org/attachments/21487/new-content-element-wizard-from-list-module.png -
Felix Kopp commented on patch set 1 04/14/13, 13:02
Dmitry, please explain to me, why this is a feature. -
Felix Kopp commented on patch set 1 04/14/13, 13:02
+1 Remove assistant and radio buttons -
Mattias Nilsson commented on patch set 1 04/14/13, 13:02
Verified; Looks good to me, but someone else must approve Sweet no ugly radio buttons anymore :) -
Mr. Jenkins commented on patch set 1 04/14/13, 13:02
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/4727/ : SUCCESS -
Mr. Jenkins commented on patch set 2 04/14/13, 13:02
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8399/ : SUCCESS -
Mr. Jenkins commented on patch set 3 04/14/13, 13:02
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8406/ : SUCCESS -
Georg Ringer commented on patch set 3 V 0 04/14/13, 13:02
by team member; Looks good to me, approved -
Georg Ringer merged patch set 4 04/14/13, 13:02