12660[TASK] Enhance Usability of Install Tool section All Configuration
Commit message
Review
-
Code review CR 0
-
Verified V 0
Files 4
Review log 17
-
Philipp Gampe commented on patch set 1 05/27/13, 17:19
Verified; I would prefer that you didn't submit this It does not yet look good if viewed from backend. -
Philipp Gampe commented on patch set 1 05/27/13, 17:19
Fails I will provide an update. -
Philipp Gampe uploaded patch set 2 05/27/13, 17:19
-
Philipp Gampe commented on patch set 2 05/27/13, 17:19
Verified; Looks good to me, but someone else must approve I changed the commit message "scroll down to very top" --> bottom ;) I also moved the CSS to install.css and took care for both standalone and backend mode. -
Ingo Pfennigstorf commented on patch set 2 05/27/13, 17:19
For backend view this seems to be good: #t3-install-form-submit-fieldset { position: fixed; margin-left: 51em; top: 80%; width: 16em; padding: 1em; } -
Ingo Pfennigstorf commented on patch set 2 05/27/13, 17:19
Fails Does not really work when scaling the browser window -
Philipp Gampe commented on patch set 3 05/27/13, 17:19
Fails; I would prefer that you didn't submit this You just dropped the style override for the standalone view (watch the color). On top of this, this has still issues with scaling the browser window. To change that, we need the fieldset to the same container the menu and the body are in. I have no time for this today ... so go ahead if you think it works. -
Ingo Pfennigstorf uploaded patch set 3 05/27/13, 17:19
-
Stefan Neufeind commented on patch set 4 05/27/13, 17:19
Looks good to me, but someone else must approve Haven't tried, but spotted no mistake (classes match, ...). Should also be easy to verify and low-critical. -
Ingo Pfennigstorf uploaded patch set 4 05/27/13, 17:19
-
Mr. Jenkins commented on patch set 1 05/27/13, 17:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/4762/ : SUCCESS -
Mr. Jenkins commented on patch set 2 05/27/13, 17:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/4764/ : SUCCESS -
Mr. Jenkins commented on patch set 3 05/27/13, 17:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/4765/ : SUCCESS -
Mr. Jenkins commented on patch set 4 05/27/13, 17:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/4772/ : SUCCESS -
Wouter Wolters commented on patch set 2 05/27/13, 17:19
Fails This fails for me in FF13. I attached a screenshot to the Forge issue -
Wouter Wolters commented on patch set 4 CR -2 06/29/13, 19:01
This can't be applied anymore on the new install tool. -2 for now. The new Install tool needs some love for UI/UX -
Ingo Pfennigstorf abandoned the change 06/30/13, 12:23