Review main Abandoned

12675[TASK] Add Domain Model and Repository to Category

Fabien Udriot CR 0 V 0 Hard +335 −0 updated 06/03/13, 20:49

Commit message

For extension developer's sake, it is convenient to provide a domain
model along with a repository. Both are relying on Extbase.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 3

Review log 14

  1. Tolleiv Nietsch commented on patch set 1 07/14/12, 14:36

    I would prefer that you didn't submit this Your classes rely on extbase - therefore extbase should either be seamlessly integrated into the Core (not beeing a replaceable extension) or these changes should be placed within their own sysext which should depend in extbase. Imho t3lib is not the right place for this. Btw. why not just place this as it's own extension in the TER?
  2. Oliver Klee commented on patch set 1 07/14/12, 14:36

    Puth in another way: If we use the correct extbase directory structure, we won't need the autoloader entries.
  3. Oliver Klee commented on patch set 1 07/14/12, 14:36

    (5 inline comments) Indeed, it should be Classes/Domain/...
  4. Oliver Klee commented on patch set 1 07/14/12, 14:36

    In that case, I'd prefer we stick to the extbase file structure conventions so the extbase autoloader can find these files. Otherwise, we'd need to add those classes to the autoloader.
  5. Oliver Hader commented on patch set 1 07/14/12, 14:36

    I'd like to create some unit-test for the basic initialization as well. Is it possible besides that to create a model or repository object (which extend Extbase classes) outside the Extbase bootstrap? If it is not, those classes should possibly be put to typo3/sysext/extbase/...
  6. Oliver Hader commented on patch set 1 07/14/12, 14:36

    Hm, since it's an Extbase model, why not putting it to typo3/sysext/extbase/Classes/Domain/Model/ - like typo3/sysext/extbase/Classes/Domain/Model/FrontendUser.php? Using this new category model needs a initialized Extbase (object manager, bootstrap, ....)
  7. Oliver Hader commented on patch set 1 07/14/12, 14:36

    Hi Tolleiv, that's basically what I've written... but here something more... I see EXT:extbase as a container for "the MVC things that get backported from time to time from FLOW3", thus spreading Extbase over the Core might be more diffucult to maintain (maybe)... Categories shall become a Core concept, e.g. like frontend users and thus the particular model will be part of Extbase.
  8. Philipp Gampe commented on patch set 1 07/14/12, 14:36

    (2 inline comments) I am unsure about the folder structure. I prefer t3lib/Classes ... for new code. Otherwise this looks good.

    Category.php:5

    Your name goes here ;)

    CategoryRepository.php:5

    name
  9. Fabien Udriot commented on patch set 1 07/14/12, 14:36

    Ok, since Extbase has it own repository, we should probably abandon this change here and re-create a new patch for the Extbase repo. However, before that, the main feature should be accepted / merged beforehand https://review.typo3.org/#/c/12672/
  10. Fabien Udriot commented on patch set 1 07/14/12, 14:36

    I like this idea better.
  11. Fabien Udriot commented on patch set 1 07/14/12, 14:36

    Ok. Will add some Unit Test to illustrate the auto-loading capability ;)
  12. Fabien Udriot commented on patch set 1 07/14/12, 14:36

    I thought about that. Though, I put it like that for remaining in-line with the FAL API conventions. If you look into t3lib/file, there isn't any Classes directory.
  13. Mr. Jenkins commented on patch set 1 07/14/12, 14:36

  14. Fabien Udriot commented on patch set 1 07/14/12, 14:36

    Abandoned Issue belongs to Extbase and should be re-created there