Review main Merged

12688[BUGFIX] Sort direction indicator in list module incorrect

Wouter Wolters CR +2 V +2 Expert +871 −861 updated 06/03/13, 20:49

Commit message

Sort direction indicator in list module incorrect

Review

  • Code review CR +2
    • Helmut Hummel +2
    • Oliver Hader +1
  • Verified V +2
    • Helmut Hummel +2
    • Oliver Hader +1

Files 7

Review log 13

  1. Oliver Hader commented on patch set 1 07/07/12, 14:11

    Verified; I would prefer that you didn't submit this Besides the remark that helmut already mentioned, it works...
  2. Helmut Hummel commented on patch set 1 07/07/12, 14:11

    I would prefer that you didn't submit this

    class.file_list.inc:607

    This fails. There was a bug in this place before which can be fixed by replacing the ? with a &
  3. Mr. Jenkins commented on patch set 1 07/07/12, 14:11

  4. Helmut Hummel uploaded patch set 3 07/07/12, 14:11

  5. Oliver Hader commented on patch set 4 07/07/12, 14:11

    Verified; Looks good to me, but someone else must approve
  6. Helmut Hummel uploaded patch set 4 07/07/12, 14:11

  7. Helmut Hummel commented on patch set 4 07/07/12, 14:11

    Verified; Looks good to me, but someone else must approve
  8. Mr. Jenkins commented on patch set 2 07/07/12, 14:11

  9. Mr. Jenkins commented on patch set 3 07/07/12, 14:11

  10. Mr. Jenkins commented on patch set 4 07/07/12, 14:11

  11. Wouter Wolters uploaded patch set 2 07/07/12, 14:11

  12. Helmut Hummel commented on patch set 4 V 0 07/07/12, 14:11

    by team member; Looks good to me, approved
  13. Helmut Hummel merged patch set 4 07/07/12, 14:11