12688[BUGFIX] Sort direction indicator in list module incorrect
Commit message
Review
-
Code review CR +2
- Helmut Hummel +2
- Oliver Hader +1
-
Verified V +2
- Helmut Hummel +2
- Oliver Hader +1
Files 7
- t3lib/stddb/tables.php+3 −0
- typo3/sysext/t3skin/images/icons/status/status-sort-asc.pngnewbinary
- typo3/sysext/t3skin/images/icons/status/status-sort-desc.pngnewbinary
- typo3/sysext/t3skin/images/sprites/t3skin.pngbinary
- typo3/sysext/t3skin/stylesheets/sprites/t3skin.css+857 −849
- typo3/class.db_list_extra.inc+2 −5
- typo3/class.file_list.inc1+9 −7
Review log 13
-
Oliver Hader commented on patch set 1 07/07/12, 14:11
Verified; I would prefer that you didn't submit this Besides the remark that helmut already mentioned, it works... -
Helmut Hummel commented on patch set 1 07/07/12, 14:11
I would prefer that you didn't submit thisclass.file_list.inc:607This fails. There was a bug in this place before which can be fixed by replacing the ? with a & -
Mr. Jenkins commented on patch set 1 07/07/12, 14:11
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/4792/ : SUCCESS -
Helmut Hummel uploaded patch set 3 07/07/12, 14:11
-
Oliver Hader commented on patch set 4 07/07/12, 14:11
Verified; Looks good to me, but someone else must approve -
Helmut Hummel uploaded patch set 4 07/07/12, 14:11
-
Helmut Hummel commented on patch set 4 07/07/12, 14:11
Verified; Looks good to me, but someone else must approve -
Mr. Jenkins commented on patch set 2 07/07/12, 14:11
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/4793/ : SUCCESS -
Mr. Jenkins commented on patch set 3 07/07/12, 14:11
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/4795/ : SUCCESS -
Mr. Jenkins commented on patch set 4 07/07/12, 14:11
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/4796/ : SUCCESS -
Wouter Wolters uploaded patch set 2 07/07/12, 14:11
-
Helmut Hummel commented on patch set 4 V 0 07/07/12, 14:11
by team member; Looks good to me, approved -
Helmut Hummel merged patch set 4 07/07/12, 14:11