12709[TASK] Adopt standard list layout for page records list
Commit message
Review
-
Code review CR +2
- Georg Ringer +2
- Stefan Neufeind +1
- Ingo Renner +1
- Wouter Wolters +1
- Felix Kopp +1
-
Verified V +2
- Georg Ringer +2
- Ingo Renner +1
- Wouter Wolters +1
- Felix Kopp +1
Issues 1
Files 4
Review log 29
Show 4 earlier messages
-
Georg Ringer merged patch set 1 08/18/12, 09:14
-
Stefan Neufeind commented on patch set 1 08/18/12, 09:14
Looks good to me, but someone else must approve -
Marcus Schwemer commented on patch set 1 08/18/12, 09:14
Verified; Looks good to me, but someone else must approve -
Georg Ringer commented on patch set 1 08/18/12, 09:14
Looks good to me, but someone else must approve
-
Steffen Ritter commented on patch set 1 V 0 08/18/12, 09:14
yeah, you're right, mixed up the screens... -
Steffen Ritter commented on patch set 1 08/18/12, 09:14
Looks good to me, but someone else must approve Afaik the issue contained a little bit more, like only the class and the padding? Is this left out on purpose? -
Felix Kopp commented on patch set 1 08/18/12, 09:14
Hi all, missid this issue sorry! I would change the behavior of the "typo3-page-stdlist" (Page module) to behave exactly like the "typo3-dblist" (List module). This table displayed in page module actually *is a table from the List module with predefined columns so there should be no visually distinctions. Two solutions for this task: style the CSS "typo3-page-stdlist" excatly like the dblist or define the list in page module based on the style of the list module. I would like to remove the superfluous and incomplete style "typo3-page-stdlist" and utilize the already optimized and state of the art typo3-dblist in page module also. Please find screenshots in the issue. -
Ingo Renner commented on patch set 2 08/18/12, 09:14
Verified; Looks good to me, but someone else must approve works for me after rebasing -
Ingo Renner uploaded patch set 3 08/18/12, 09:14
-
Ingo Renner uploaded patch set 4 08/18/12, 09:14
-
Ingo Renner commented on patch set 4 08/18/12, 09:14
Verified; Looks good to me, but someone else must approve works, looks good. * rebased * fixed the CGL issue please give your votes again -
Stefan Neufeind commented on patch set 4 08/18/12, 09:14
Looks good to me, but someone else must approve -
Marcus Schwemer commented on patch set 2 08/18/12, 09:14
Verified; Looks good to me, but someone else must approve -
Georg Ringer commented on patch set 2 08/18/12, 09:14
Verified; Looks good to me, but someone else must approve -
Georg Ringer commented on patch set 4 V 0 08/18/12, 09:14
by team member; Looks good to me, approved -
Felix Kopp uploaded patch set 2 08/18/12, 09:14
-
Felix Kopp commented on patch set 2 08/18/12, 09:14
Verified; Looks good to me, but someone else must approve -
Felix Kopp commented on patch set 4 08/18/12, 09:14
Verified; Looks good to me, but someone else must approve -
Mr. Jenkins commented on patch set 1 08/18/12, 09:14
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/4831/ : SUCCESS -
Mr. Jenkins commented on patch set 2 08/18/12, 09:14
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/5234/ : SUCCESS -
Mr. Jenkins commented on patch set 3 08/18/12, 09:14
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/5304/ : SUCCESS -
Mr. Jenkins commented on patch set 4 08/18/12, 09:14
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/5305/ : SUCCESS -
Wouter Wolters commented on patch set 1 08/18/12, 09:14
Steffen: As you can read in a message in this patch set I asked Felix to add his comments from the Forge issue in this patch. I'm not sure if I understand his comment correct so I hope he can implement it.class.tx_cms_layout.php:882CGL says always add { } -
Wouter Wolters commented on patch set 1 08/18/12, 09:14
@Felix, I agree that this table should look like the list table view. So +1 from me -
Wouter Wolters commented on patch set 1 08/18/12, 09:14
@Felix I pushed the changes. You mentioned in the ticket something about the headers. Can you improve this patch for that? -
Wouter Wolters commented on patch set 2 1 comment 08/18/12, 09:14
Looks good to me, but someone else must approve Will test tomorrow -
Wouter Wolters voted on patch set 2 V 0 08/18/12, 09:14
-
Wouter Wolters commented on patch set 4 08/18/12, 09:14
Verified; Looks good to me, but someone else must approve -
Felix Kopp commented on patch set 4 08/18/12, 09:14
Nice, thank you