12714[BUGFIX] l10n_mode for "pages" table and group fields.
Commit message
Review
-
Code review CR +2
- Markus Klein +2
- Wouter Wolters +1
-
Verified V +2
- Markus Klein +2
- Wouter Wolters +1
Files 2
Review log 47
Show 22 earlier messages
-
Georg Ringer commented on patch set 2 05/27/13, 17:19
(3 inline comments)class.t3lib_page.php:322strict comparison pleaseclass.t3lib_page.php:1406IMO this is booleanclass.t3lib_page.php:1414$value == 0 -
Michael Klapper uploaded patch set 3 05/27/13, 17:19
-
Michael Klapper commented on patch set 3 05/27/13, 17:19
Verified; Looks good to me, but someone else must approve -
Johannes Feustel commented on patch set 3 05/27/13, 17:19
Verified; Looks good to me, but someone else must approve -
Johannes Feustel uploaded patch set 4 05/27/13, 17:19
-
Johannes Feustel uploaded patch set 5 05/27/13, 17:19
-
Tolleiv Nietsch commented on patch set 6 05/27/13, 17:19
Looks good to me, but someone else must approve -
Johannes Feustel uploaded patch set 6 05/27/13, 17:19
-
Philipp Gampe commented on patch set 2 05/27/13, 17:19
I just changed the spacing of the commit message. -
Philipp Gampe uploaded patch set 2 05/27/13, 17:19
-
Mr. Jenkins commented on patch set 1 05/27/13, 17:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/4838/ : SUCCESS -
Mr. Jenkins commented on patch set 2 05/27/13, 17:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/4839/ : SUCCESS -
Mr. Jenkins commented on patch set 3 05/27/13, 17:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/4884/ : SUCCESS -
Mr. Jenkins commented on patch set 4 05/27/13, 17:19
Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/8336/ : FAILURE -
Mr. Jenkins commented on patch set 5 05/27/13, 17:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8337/ : SUCCESS -
Mr. Jenkins commented on patch set 6 05/27/13, 17:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8338/ : SUCCESS -
Wouter Wolters commented on patch set 3 05/27/13, 17:19
(4 inline comments)class.t3lib_page.php:322space after ifclass.t3lib_page.php:332Inline comments need to be intended by one tabclass.t3lib_page.php:1417Can we use strict comparrison here?class.t3lib_page.php:1423Can we use strict comparrison here? -
Christian Zenker commented on patch set 6 V -1 CR -1 07/15/13, 14:00
The patch has a bug so that mergeIfNotBlank on group columns *never* works.PageRepository.php:1211ambigious name. This variable just stores if the field could be overlaid.PageRepository.php:1215This line does not do what you would expect! "string" == 0 is *always* TRUE in PHP. see http://php.net/manual/en/types.comparisons.php#types.comparisions-loose This is why group fields are always considered empty with mergeIfNotBlank.PageRepository.php:1221This condition is very to understand even though it could be very simple. -
Markus Klein commented on patch set 6 CR -1 07/15/13, 14:04
6.2 missing -
Christian Zenker uploaded patch set 7 07/15/13, 14:08
-
Mr. Jenkins commented on patch set 7 07/15/13, 14:09
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9610/ : SUCCESS -
Markus Klein commented on patch set 7 CR -1 07/15/13, 14:17
PageRepository.php:335speaking names please for new code!PageRepository.php:1209protectedPageRepository.php:1210isset() check firstPageRepository.php:1213No early return please. Use a $result variablePageRepository.php:1219combine into 1 if pleasePageRepository.php:1225no return here; same as abovePageRepositoryTest.php:128Please adhere naming conventions for tests. @test in docheader and name of function is: <nameOfFunctionUnderTest><WhatIsTested> Look at other tests, for details please.
-
Christian Zenker uploaded patch set 8 07/15/13, 14:38
-
Mr. Jenkins commented on patch set 8 07/15/13, 14:39
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9611/ : SUCCESS -
Markus Klein uploaded patch set 9 07/15/13, 15:02
-
Mr. Jenkins commented on patch set 9 07/15/13, 15:03
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9612/ : SUCCESS -
Markus Klein commented on patch set 9 CR +1 07/15/13, 15:03
Rebased on current master. Can some unittest guru please take a look if the tests are ok? I'm not sure about the reflection stuff. Thx. -
Christian Zenker voted on patch set 9 V +1 CR +1 07/16/13, 12:46
-
Oliver Klee commented on patch set 9 07/16/13, 13:22
The reflection stuff is quite dirty. Instead, I'd propose to use one of the following approaches: a) make the method public b) test the method/the behavior through some other (public) method c) use $this->getAccessibleMock to make the protected method callable -
Markus Klein commented on patch set 9 07/16/13, 20:58
a) no go: We can't introduce new API in a bugfix b) too difficult I fear c) that's what I thought -
Markus Klein uploaded patch set 10 07/16/13, 21:35
-
Mr. Jenkins commented on patch set 10 07/16/13, 21:36
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9643/ : SUCCESS -
Christian Zenker voted on patch set 10 CR +1 08/14/13, 16:00
-
Markus Klein uploaded patch set 11 08/14/13, 17:03
-
Markus Klein commented on patch set 11 CR +1 08/14/13, 17:04
Rebased and CGL fixes -
Mr. Jenkins commented on patch set 11 08/14/13, 17:04
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/10041/ : SUCCESS -
Markus Klein voted on patch set 11 V +1 11/10/13, 11:42
-
Markus Klein voted on patch set 11 V 0 11/10/13, 11:45
-
Markus Klein uploaded patch set 12 11/10/13, 11:49
-
Markus Klein voted on patch set 12 V +1 CR +1 11/10/13, 11:51
-
Mr. Jenkins commented on patch set 12 11/10/13, 12:04
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/11946/ : SUCCESS -
Markus Klein rebased onto patch set 12 11/19/13, 00:02
-
Markus Klein voted on patch set 13 V +1 CR +1 11/19/13, 00:02
-
Mr. Jenkins commented on patch set 13 11/19/13, 00:28
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/12155/ : SUCCESS -
Wouter Wolters commented on patch set 13 V +1 CR +1 11/19/13, 22:07
Only verified with the unittest -
Markus Klein voted on patch set 13 V +2 CR +2 11/19/13, 22:13
-
Markus Klein merged patch set 14 11/19/13, 22:13