Review main Merged

1274[BUGFIX] Also crop when maxCharacters < first word

Peter Beernink CR +2 V +2 Easy +31 −7 updated 06/03/13, 20:49

Commit message

When maxCharacters is equal or less then the length of the first word,
the whole string was returned when 'crop to word' is enabled instead of
the only the cropped part.

Review

  • Code review CR +2
    • Steffen Gebert +2
  • Verified V +2
    • Steffen Gebert +2

Issues 1

Files 2

Review log 13

  1. Peter Beernink uploaded patch set 2 05/08/11, 11:24

  2. Peter Beernink commented on patch set 2 05/08/11, 11:24

    You'r both right. The patch have been modified to meet the failing tests. The HTML dataprovider in the test has been extended to also cover this issue.
  3. Stefan Neufeind commented on patch set 2 05/08/11, 11:24

    Looks good to me, but someone else must approve
  4. Steffen Gebert uploaded patch set 3 05/08/11, 11:24

  5. Steffen Gebert commented on patch set 3 V 0 05/08/11, 11:24

    by team member; Looks good to me, approved
  6. Jigal van Hemert commented on patch set 1 05/08/11, 11:24

    These functions are covered by unit tests and they don't show this problem. Maybe it's a good idea to add unit tests that show the problem? That would make sure that future changes don't bring this bug back.
  7. Philipp Gampe commented on patch set 1 05/08/11, 11:24

    Fails Please check those unit tests: cropHtmlWithDataProvider with data set "iso-8859-1 text with entities 14|...|1" cropHTML failed with settings: "14|...|1" and charset "iso-8859-1" Failed asserting that <string:Kasper...> is equal to <string:Kasper Sk&aring;rh&oslash;j...>.
  8. Philipp Gampe commented on patch set 2 05/08/11, 11:24

    Looks good to me, but someone else must approve
  9. Philipp Gampe commented on patch set 2 V 0 05/08/11, 11:24

    testing by Unit Tests
  10. Mr. Jenkins commented on patch set 1 05/08/11, 11:24

  11. Mr. Jenkins commented on patch set 2 05/08/11, 11:24

  12. Mr. Jenkins commented on patch set 3 05/08/11, 11:24

  13. Steffen Gebert merged patch set 3 05/08/11, 11:24