Review TYPO3_4-6 Abandoned

12763[BUGFIX] Invalid shortcut target on translated pages

Oliver Hader CR 0 V 0 Easy +43 −4 updated 06/03/13, 20:49

Commit message

A feature to resolve shortcut links directly in menu rendering
does not consider the overlay behaviour of the "shortcut" value.

TSFE first uses the "shortcut" value of the original/default
page and then serves for possible translated alternatives
(tslib_fe::checkTranslatedShortcut()). In menu rendering it's
the other way round, the translated overlay (if any) is used
directly - the fallback to use the "shortcut" value of the
original/default page is not implemented.

This change introduces the fallback when rendering menus, which
will take the "shortcut" value of the default language if the
value in the overlay is empty.

Review

  • Code review CR 0
  • Verified V 0

Files 1

Review log 3

  1. Oliver Hader uploaded patch set 2 03/01/13, 11:03

  2. Oliver Hader uploaded patch set 3 03/01/13, 11:03

  3. Oliver Hader commented on patch set 3 03/01/13, 11:03

    Abandoned TYPO3 4.6 branch is at the end of bug fixing period. Only priority changes will be considered (compatibility fixes and security fixes) until end of April 2013.