Review TYPO3_4-7 Abandoned

12764[BUGFIX] Invalid shortcut target on translated pages

Oliver Hader CR 0 V 0 Easy +43 −4 updated 07/05/13, 12:14

Commit message

A feature to resolve shortcut links directly in menu rendering
does not consider the overlay behaviour of the "shortcut" value.

TSFE first uses the "shortcut" value of the original/default
page and then serves for possible translated alternatives
(tslib_fe::checkTranslatedShortcut()). In menu rendering it's
the other way round, the translated overlay (if any) is used
directly - the fallback to use the "shortcut" value of the
original/default page is not implemented.

This change introduces the fallback when rendering menus, which
will take the "shortcut" value of the default language if the
value in the overlay is empty.

Review

  • Code review CR 0
  • Verified V 0

Files 1

Review log 8

  1. Oliver Hader uploaded patch set 2 05/27/13, 17:19

  2. Oliver Hader commented on patch set 2 05/27/13, 17:19

    @Wouter: That's not the reason to give a -1 on a code review... Besides that the implementation of 6.0 and 4.7 is different due to the namespaces changes - therefore it needs independent reviews
  3. Oliver Hader uploaded patch set 3 05/27/13, 17:19

  4. Oliver Hader commented on patch set 3 05/27/13, 17:19

    Hm, not the ideal behaviour. It's required to wait for other branches since the implementation in master might change during review. However the "-1" hinders others from reviewing since it seems that "something" needs to be done. What we need is a "on hold" flag in Gerrit - since it seems to be easier for me to create patches for all branches when I'm on the topic and not to do that after some weeks when details have been forgotten...
  5. Philipp Gampe commented on patch set 3 05/27/13, 17:19

    @Oliver jumping in here: You should -1 your own patch then and add a link to the master commit. Once merged, just remove the -1 and maybe add the reviews of the master patch to the reviewers list of the backport (or merge directly).
  6. Wouter Wolters commented on patch set 2 05/27/13, 17:19

    I would prefer that you didn't submit this Master needs to be merged first.
  7. Wouter Wolters commented on patch set 3 05/27/13, 17:19

    Looks good to me, but someone else must approve @Oliver, sorry but I only follow what others are doing when master needs to be reviewed first. They also give a -1 on the patch.
  8. Steffen Ritter abandoned the change 07/05/13, 12:14

    Only Security Fixes for TYPO3 4.7 since Mai 2013