12765[BUGFIX] Invalid shortcut target on translated pages
Commit message
Review
-
Code review CR +2
- Stefan Neufeind +2
- Markus Klein +1
- Wouter Wolters +1
-
Verified V +2
- Stefan Neufeind +2
- Markus Klein +1
Files 1
Review log 24
-
Stefan Neufeind commented on patch set 2 05/27/13, 17:19
Looks good to me, but someone else must approve just some comment-nitpicksclass.tslib_menu.php:1379severs: serves? Removed in which version exactly? Maybe add an @deprecated for 4.6/4.7? -
Oliver Hader uploaded patch set 2 05/27/13, 17:19
-
Oliver Hader uploaded patch set 3 05/27/13, 17:19
-
Xavier Perseguers commented on patch set 2 05/27/13, 17:19
Verified; Looks good to me, but someone else must approve -
Robert Heel commented on patch set 2 V 0 05/27/13, 17:19
Works like in the old typo3 version! -
Mr. Jenkins commented on patch set 2 05/27/13, 17:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/4856/ : SUCCESS -
Mr. Jenkins commented on patch set 3 05/27/13, 17:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/6286/ : SUCCESS -
Wouter Wolters commented on patch set 2 05/27/13, 17:19
Looks good to me, but someone else must approve -
Stefan Neufeind commented on patch set 3 CR +1 11/12/13, 14:56
makes sense by reading imho, taking into account the explanation aboveonly 6.x now? -
Pascal Dürsteler voted on patch set 3 CR +1 11/12/13, 14:59
-
Markus Klein commented on patch set 3 11/12/13, 15:25
AbstractMenuContentObject.php:1373We still have the page_lang_overlay stuff, so this line is invalidAbstractMenuContentObject.php:1378remove this line hereAbstractMenuContentObject.php:1380protected nowAbstractMenuContentObject.php:1381superfluous ()AbstractMenuContentObject.php:1393no indentation anymore -
Stefan Neufeind voted on patch set 3 CR 0 11/12/13, 15:26
-
Markus Klein uploaded patch set 4 01/16/14, 22:31
-
Markus Klein voted on patch set 4 CR +1 01/16/14, 22:31
-
Stefan Neufeind voted on patch set 4 CR +1 01/16/14, 22:35
-
Mr. Jenkins commented on patch set 4 01/16/14, 22:46
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/13062/ : SUCCESS -
Markus Klein rebased onto patch set 4 02/17/14, 15:08
-
Markus Klein voted on patch set 5 CR +1 02/17/14, 15:08
-
Markus Klein voted on patch set 5 V +1 02/17/14, 15:09
-
Wouter Wolters voted on patch set 5 CR +1 02/17/14, 21:06
-
Mr. Jenkins commented on patch set 5 02/17/14, 22:32
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/14115/ : SUCCESS https://ci.typo3.org/job/typo3-v4-core-gerrit/14114/ : SUCCESS -
Stefan Neufeind commented on patch set 5 V +2 CR +2 02/17/14, 22:57
* Checked that it works fine for the described fallback-case. forge-entry seems to suggest that was the behaviour until 4.5 which got changed/broken unexpectedly. * Checked that if in the translation you point the target somewhere else, that works as well and the value from the default-entry is not used anymore. -
Stefan Neufeind merged patch set 6 02/17/14, 22:57
-
Stefan Neufeind commented on patch set 6 02/17/14, 22:57
Cherry Picked This patchset was cherry picked to change: I26a9eb4813c6b99327043b0a764ec7ff80b6a905