Review main Merged

12765[BUGFIX] Invalid shortcut target on translated pages

Oliver Hader CR +2 V +2 Easy +41 −2 updated 02/17/14, 22:57

Commit message

A feature to resolve shortcut links directly in menu rendering
does not consider the overlay behaviour of the "shortcut" value.

TSFE first uses the "shortcut" value of the original/default
page and then serves for possible translated alternatives
(TypoScriptFrontendController::checkTranslatedShortcut()).
In menu rendering it's the other way round, the translated
overlay (if any) is used directly - the fallback to use the
"shortcut" value of the original/default page is not implemented.

This change introduces the fallback when rendering menus, which
will take the "shortcut" value of the default language if the
value in the overlay is empty.

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Markus Klein +1
    • Wouter Wolters +1
  • Verified V +2
    • Stefan Neufeind +2
    • Markus Klein +1

Files 1

Review log 24

  1. Stefan Neufeind commented on patch set 2 05/27/13, 17:19

    Looks good to me, but someone else must approve just some comment-nitpicks

    class.tslib_menu.php:1379

    severs: serves? Removed in which version exactly? Maybe add an @deprecated for 4.6/4.7?
  2. Oliver Hader uploaded patch set 2 05/27/13, 17:19

  3. Oliver Hader uploaded patch set 3 05/27/13, 17:19

  4. Xavier Perseguers commented on patch set 2 05/27/13, 17:19

    Verified; Looks good to me, but someone else must approve
  5. Robert Heel commented on patch set 2 V 0 05/27/13, 17:19

    Works like in the old typo3 version!
  6. Mr. Jenkins commented on patch set 2 05/27/13, 17:19

  7. Mr. Jenkins commented on patch set 3 05/27/13, 17:19

  8. Wouter Wolters commented on patch set 2 05/27/13, 17:19

    Looks good to me, but someone else must approve
  9. Stefan Neufeind commented on patch set 3 CR +1 11/12/13, 14:56

    makes sense by reading imho, taking into account the explanation above
    only 6.x now?
  10. Pascal Dürsteler voted on patch set 3 CR +1 11/12/13, 14:59

  11. Markus Klein commented on patch set 3 11/12/13, 15:25

    AbstractMenuContentObject.php:1373

    We still have the page_lang_overlay stuff, so this line is invalid

    AbstractMenuContentObject.php:1378

    remove this line here

    AbstractMenuContentObject.php:1380

    protected now

    AbstractMenuContentObject.php:1381

    superfluous ()

    AbstractMenuContentObject.php:1393

    no indentation anymore
  12. Stefan Neufeind voted on patch set 3 CR 0 11/12/13, 15:26

  13. Markus Klein uploaded patch set 4 01/16/14, 22:31

  14. Markus Klein voted on patch set 4 CR +1 01/16/14, 22:31

  15. Stefan Neufeind voted on patch set 4 CR +1 01/16/14, 22:35

  16. Mr. Jenkins commented on patch set 4 01/16/14, 22:46

  17. Markus Klein rebased onto patch set 4 02/17/14, 15:08

  18. Markus Klein voted on patch set 5 CR +1 02/17/14, 15:08

  19. Markus Klein voted on patch set 5 V +1 02/17/14, 15:09

  20. Wouter Wolters voted on patch set 5 CR +1 02/17/14, 21:06

  21. Mr. Jenkins commented on patch set 5 02/17/14, 22:32

  22. Stefan Neufeind commented on patch set 5 V +2 CR +2 02/17/14, 22:57

    * Checked that it works fine for the described fallback-case. forge-entry seems to suggest that was the behaviour until 4.5 which got changed/broken unexpectedly. * Checked that if in the translation you point the target somewhere else, that works as well and the value from the default-entry is not used anymore.
  23. Stefan Neufeind merged patch set 6 02/17/14, 22:57

  24. Stefan Neufeind commented on patch set 6 02/17/14, 22:57

    Cherry Picked This patchset was cherry picked to change: I26a9eb4813c6b99327043b0a764ec7ff80b6a905