Review main Abandoned

12794[BUGFIX] Uncaught TYPO3 Exception: Parameter Error in tslib/showpic.php

Stanislas Rolland CR 0 V 0 Easy +1 −1 updated 06/03/13, 20:49

Commit message

Problem: Uncaught TYPO3 Exception: Parameter Error: Wrong parameters
sent is thrown in tslib/showpic.php
Solution: the filename should be rawurldecoded in order to calculate
the correct md5 value.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 8

  1. Stanislas Rolland commented on patch set 1 10/09/12, 15:04

    Just a mistake.
  2. Markus Klein commented on patch set 1 10/09/12, 15:04

    (1 inline comment)
    "master": Is this a new convention or just a mistake?
  3. Markus Klein commented on patch set 1 10/09/12, 15:04

    @Marcus: I didn't dig too much into the issues, but by just looking at the code, I don't see any connection between this change and https://review.typo3.org/12867. Can you explain, how this issue is solved by the other?
  4. Helmut Hummel commented on patch set 1 10/09/12, 15:04

    I would prefer that you didn't submit this I agree with Marcus. If we need to urldecode the filename in showpic, then it is urlencoded twice somewhere. If this latter is the case (I never ran in such problems), we need to fix the double urlencoding instead.
  5. Marcus Krause commented on patch set 1 10/09/12, 15:04

    Any chance this can be dropped in favour of #39052?
  6. Marcus Krause commented on patch set 1 10/09/12, 15:04

    Do we have an issue which is resolved by a rawurldecode function call? Wrong parameters can happen through changing the encryption key. When you do this, TYPO3 responds with this exception and delivers HTTP Code 500 (Internal server error) All the showpic issues IMHO boil down to: 1. there's no program error in showpic 2. accept that showpic link get outdated 3. don't throw exceptions in such cases
  7. Mr. Jenkins commented on patch set 1 10/09/12, 15:04

  8. Stanislas Rolland commented on patch set 1 10/09/12, 15:04

    Abandoned