12797[BUGFIX] Check minitems for TCAtree
Commit message
Review
-
Code review CR +2
- Oliver Hader +2
- Stefan Neufeind +1
- Wouter Wolters +1
- Marcus Schwemer +1
-
Verified V +2
- Oliver Hader +2
- Marcus Schwemer +1
Issues 1
Files 3
Review log 10
-
Mario Rimann commented on patch set 1 03/01/13, 17:25
Abandoned Confirmed, t3lib_Utility_Math was not available in 4.5 - will mark this change as "given up" in the backporting list. -
Mario Rimann commented on patch set 1 03/01/13, 17:25
Restored Hehe, abandoned too fast maybe. What about taking the functionality from that (missing) method out of t3lib_Utility_Math to get this change to work in 4.5? -
Mario Rimann uploaded patch set 2 03/01/13, 17:25
-
Mario Rimann commented on patch set 2 03/01/13, 17:25
Changeset 2 just checks the config setting. As we don't really used the full power of t3lib_Utility_Math::forceIntegerInRange anyway, I think this could be a fair deal to get this bugfix into 4.5. -
Stefan Neufeind commented on patch set 2 03/01/13, 17:25
Looks good to me, but someone else must approve Backported from master -
Marcus Schwemer commented on patch set 1 03/01/13, 17:25
Fails; I would prefer that you didn't submit this Verify: Fatal error: Class 't3lib_utility_Math' not found in <...>/t3lib/class.t3lib_tceforms.php on line 1571 Code Review: t3lib_utility_Math::forceIntegerInRange was introduced in 4.6 and is not available in 4.5. Tested with ext news as mentioned on forge. -
Marcus Schwemer commented on patch set 2 03/01/13, 17:25
Verified; Looks good to me, but someone else must approve -
Oliver Hader commented on patch set 2 V 0 03/01/13, 17:25
by team member; Looks good to me, approved -
Wouter Wolters commented on patch set 2 03/01/13, 17:25
Looks good to me, but someone else must approve -
Oliver Hader merged patch set 3 03/01/13, 17:25