Review TYPO3_4-5 Abandoned

12819[BUGFIX] Make generated thumbnails browser-cachable

Mario Rimann CR 0 V 0 Normal +37 −35 updated 06/03/13, 20:49

Commit message

Thumbnail generation code appends current timestamp in each
invocation of the thumbnail generation script. This is useless
because it prevents caching. Removing this timestamp will not
cause any issues with old vs new versions because the URL
includes an md5 checksum of the file size and file timestamp.
So when the file is updated, the md5 sum will change. The
patch also changes short md5 to full md5.

Additionally proper last-modified, expires and etag headers
are sent.

Review

  • Code review CR 0
  • Verified V 0

Files 5

Review log 7

  1. Marcus Schwemer commented on patch set 1 04/17/13, 08:04

    I would prefer that you didn't submit this See inline comment

    thumbs.php:258

    Seems that there went somthing wrong.
  2. Marcus Schwemer commented on patch set 1 04/17/13, 08:04

    I'll take care of the change
  3. Mario Rimann commented on patch set 2 04/17/13, 08:04

    Ping
  4. Stefan Neufeind commented on patch set 2 04/17/13, 08:04

    Looks good to me, but someone else must approve Backported from master
  5. Marcus Schwemer uploaded patch set 2 04/17/13, 08:04

  6. Wouter Wolters commented on patch set 2 04/17/13, 08:04

    Looks good to me, but someone else must approve
  7. Dmitry Dulepov commented on patch set 2 04/17/13, 08:04

    Abandoned This is already merged to 6.x versions. Only major changes go to 4.x, so 4.x is not getting this.