Review TYPO3_4-6 Merged

12820[BUGFIX] Make generated thumbnails browser-cachable

Mario Rimann CR +2 V +2 Normal +34 −33 updated 06/03/13, 20:49

Commit message

Thumbnail generation code appends current timestamp in each
invocation of the thumbnail generation script. This is useless
because it prevents caching. Removing this timestamp will not
cause any issues with old vs new versions because the URL
includes an md5 checksum of the file size and file timestamp.
So when the file is updated, the md5 sum will change. The
patch also changes short md5 to full md5.

Additionally proper last-modified, expires and etag headers
are sent.

Review

  • Code review CR +2
    • Xavier Perseguers +2
    • Wouter Wolters +1
    • Marcus Schwemer +1
    • Philipp Gampe +1
  • Verified V +2
    • Xavier Perseguers +2

Files 5

Review log 7

  1. Marcus Schwemer commented on patch set 1 10/16/12, 09:50

    Looks good to me, but someone else must approve

    thumbs.php:235

    There is one bracket "( ... )" too much.
  2. Marcus Schwemer commented on patch set 1 1 comment 10/16/12, 09:50

    I would prefer that you didn't submit this See inline comment. I'll take care of.
  3. Marcus Schwemer commented on patch set 1 10/16/12, 09:50

    (1 inline comment)
  4. Philipp Gampe commented on patch set 1 10/16/12, 09:50

    Looks good to me, but someone else must approve

    thumbs.php:235 Reply

    This is required by CGL. It tells the reader that the assignment is on purpose and not a mistake.
  5. Wouter Wolters commented on patch set 1 10/16/12, 09:50

    Looks good to me, but someone else must approve
  6. Xavier Perseguers commented on patch set 1 V 0 10/16/12, 09:50

    by team member; Looks good to me, approved
  7. Xavier Perseguers merged patch set 1 10/16/12, 09:50