12820[BUGFIX] Make generated thumbnails browser-cachable
Commit message
Review
-
Code review CR +2
- Xavier Perseguers +2
- Wouter Wolters +1
- Marcus Schwemer +1
- Philipp Gampe +1
-
Verified V +2
- Xavier Perseguers +2
Files 5
Review log 7
-
Marcus Schwemer commented on patch set 1 10/16/12, 09:50
Looks good to me, but someone else must approvethumbs.php:235There is one bracket "( ... )" too much. -
Marcus Schwemer commented on patch set 1 1 comment 10/16/12, 09:50
I would prefer that you didn't submit this See inline comment. I'll take care of. -
Marcus Schwemer commented on patch set 1 10/16/12, 09:50
(1 inline comment) -
Philipp Gampe commented on patch set 1 10/16/12, 09:50
Looks good to me, but someone else must approvethumbs.php:235ReplyThis is required by CGL. It tells the reader that the assignment is on purpose and not a mistake. -
Wouter Wolters commented on patch set 1 10/16/12, 09:50
Looks good to me, but someone else must approve -
Xavier Perseguers commented on patch set 1 V 0 10/16/12, 09:50
by team member; Looks good to me, approved -
Xavier Perseguers merged patch set 1 10/16/12, 09:50