Review TYPO3_4-6 Merged

12821[BUGFIX] PHP warnings may show up in the List module

Mario Rimann CR +2 V +2 Normal +47 −39 updated 06/03/13, 20:49

Commit message

If the table is defined in $TCA but it misses "columns" array,
there will be a warning in the List module when searching for
any phrase. Implement a check that "columns" entry exists and
write a log message if it does not.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Marcus Schwemer +1
  • Verified V +2
    • Christian Kuhn +2
    • Marcus Schwemer +1

Issues 1

Files 1

Review log 3

  1. Marcus Schwemer commented on patch set 1 07/30/12, 16:20

    Verified; Looks good to me, but someone else must approve
  2. Christian Kuhn commented on patch set 1 V 0 07/30/12, 16:20

    by team member; Looks good to me, approved
  3. Christian Kuhn merged patch set 1 07/30/12, 16:20