Review TYPO3_4-5 Merged

12824[BUGFIX] PHP warnings may show up in the List module

Mario Rimann CR +2 V +2 Normal +48 −31 updated 06/03/13, 20:49

Commit message

If the table is defined in $TCA but it misses "columns" array,
there will be a warning in the List module when searching for
any phrase. Implement a check that "columns" entry exists and
write a log message if it does not.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Marcus Schwemer +1
  • Verified V +2
    • Christian Kuhn +2
    • Marcus Schwemer +1

Issues 1

Files 1

Review log 6

  1. Marcus Schwemer commented on patch set 1 07/30/12, 16:21

    Verified; Looks good to me, but someone else must approve See inline comment (CGL). Can be fixed on commit.

    class.db_list.inc:808

    Tab after ")" should be a single whitespace
  2. Oliver Klee commented on patch set 1 07/30/12, 16:21

    (1 inline comment)

    class.db_list.inc:772

    Missing space after foreach.
  3. Marcus Schwemer commented on patch set 2 07/30/12, 16:21

    Verified; Looks good to me, but someone else must approve
  4. Oliver Klee uploaded patch set 2 07/30/12, 16:21

  5. Christian Kuhn commented on patch set 2 V 0 07/30/12, 16:21

    by team member; Looks good to me, approved
  6. Christian Kuhn merged patch set 2 07/30/12, 16:21