12824[BUGFIX] PHP warnings may show up in the List module
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Marcus Schwemer +1
-
Verified V +2
- Christian Kuhn +2
- Marcus Schwemer +1
Issues 1
Files 1
Review log 6
-
Marcus Schwemer commented on patch set 1 07/30/12, 16:21
Verified; Looks good to me, but someone else must approve See inline comment (CGL). Can be fixed on commit.class.db_list.inc:808Tab after ")" should be a single whitespace -
Oliver Klee commented on patch set 1 07/30/12, 16:21
(1 inline comment)class.db_list.inc:772Missing space after foreach. -
Marcus Schwemer commented on patch set 2 07/30/12, 16:21
Verified; Looks good to me, but someone else must approve -
Oliver Klee uploaded patch set 2 07/30/12, 16:21
-
Christian Kuhn commented on patch set 2 V 0 07/30/12, 16:21
by team member; Looks good to me, approved -
Christian Kuhn merged patch set 2 07/30/12, 16:21