Review TYPO3_4-5 Merged

12837[BUGFIX] Page within a mountpoint using Show Content from Page fatals

Mario Rimann CR +2 V +2 Easy +1 −0 updated 07/22/13, 16:19

Commit message

When pages:content_from_pid is used, the TSFE for the current object
will be cloned to a temporary object for the page to get the content
from.  In this temporary object, the id for the page will be changed to
the contents of content_from_pid.  However, the MP variable will not be
changed.

This results in a TSFE object with the wrong MP variable connected to
the id.  Within this temporary object the rootline will be calculated,
which will be empty, because of the wrong MP variable.  This triggers
"The requested page didn't have a proper connection to the tree-root"

This bugfix fixes this by emptying the MP variable.

Review

  • Code review CR +2
    • Ernesto Baschny +2
  • Verified V +2
    • Ernesto Baschny +2

Files 1

Review log 7

  1. Mario Rimann uploaded patch set 2 05/27/13, 17:19

  2. Marcus Schwemer commented on patch set 2 05/27/13, 17:19

    Looks good to me, but someone else must approve
  3. Marcus Schwemer commented on patch set 2 05/27/13, 17:19

    See my question for testing in the ticket itsself.
  4. Ernesto Baschny uploaded patch set 3 07/22/13, 16:16

  5. Ernesto Baschny uploaded patch set 4 07/22/13, 16:17

  6. Ernesto Baschny commented on patch set 4 V +2 CR +2 07/22/13, 16:19

    I was able to reproduce it in 4.5-dev and the solution really fixes it. Might be PHP version dependent. Since this fix is already in 4.7+ for some time now, it's pretty safe to close the issue by merging this.
  7. Ernesto Baschny merged patch set 5 07/22/13, 16:19