12844[BUGFIX] Two mailforms on a page cause error on field validation
Commit message
Review
-
Code review CR +2
- Wouter Wolters +2
-
Verified V +2
- Wouter Wolters +2
Files 2
Review log 24
-
Stefan Neufeind commented on patch set 1 05/27/13, 17:19
Looks good to me, but someone else must approve looks trivial but useful to have -
Stefan Neufeind uploaded patch set 2 05/27/13, 17:19
-
Stefan Neufeind commented on patch set 2 05/27/13, 17:19
Looks good to me, but someone else must approve hand-rebased removed one debug()-call from previous patch-set :-) -
Stefan Neufeind commented on patch set 3 05/27/13, 17:19
Looks good to me, but someone else must approve hand-rebased removed one debug()-call from original patch-set :-) -
Stefan Neufeind uploaded patch set 3 05/27/13, 17:19
-
Stefan Neufeind uploaded patch set 4 05/27/13, 17:19
-
Stefan Neufeind commented on patch set 4 05/27/13, 17:19
The getUniqueId()-function already contained a check for a non-set formName, so we can make use of that as well. Moved that part over. Also took care of adding a description and the Releases-line to commit-msg. -
Alexander Opitz commented on patch set 3 05/27/13, 17:19
I would prefer that you didn't submit this Looks good to me, please fix the small hints so we get this ready.Can you add a short description of what you do to fix the problem?The right order would be 6.1, 6.0, 4.7, 4.5 -
Alexander Opitz commented on patch set 4 05/27/13, 17:19
Looks good to me, but someone else must approve -
Jigal van Hemert commented on patch set 3 05/27/13, 17:19
Verified; I would prefer that you didn't submit this Please fix commit message (describe what it does instead of the bug report title; proper version list). If I have the time available I'll push an updated patch. -
Mr. Jenkins commented on patch set 1 05/27/13, 17:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/4891/ : SUCCESS -
Mr. Jenkins commented on patch set 2 05/27/13, 17:19
Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/6858/ : FAILURE -
Mr. Jenkins commented on patch set 3 05/27/13, 17:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/6860/ : SUCCESS -
Mr. Jenkins commented on patch set 4 05/27/13, 17:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8425/ : SUCCESS -
Stefan Neufeind commented on patch set 4 CR +1 07/19/13, 09:45
6.2, 6.1, 6.0, 4.5 -
Ernesto Baschny updated the commit message in patch set 4 07/21/13, 21:05
-
Mr. Jenkins commented on patch set 5 07/21/13, 21:06
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9697/ : SUCCESS -
Stefan Neufeind commented on patch set 5 V +1 CR +1 07/21/13, 23:03
old form-functionality. To test disable extension "form" you might have installed. -
Wouter Wolters uploaded patch set 6 07/22/13, 11:12
-
Wouter Wolters commented on patch set 6 V +2 CR +2 07/22/13, 11:13
Only rebased, merged with previous votes taken into account -
Wouter Wolters merged patch set 7 07/22/13, 11:13
-
Wouter Wolters commented on patch set 7 07/22/13, 11:13
Cherry Picked This patchset was cherry picked to change: Ifd33c5130c383f3afc3e5e6d80c1be017f25ec5b -
Mr. Jenkins commented on patch set 6 07/22/13, 11:13
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9698/ : SUCCESS -
Wouter Wolters commented on patch set 7 07/22/13, 11:14
Cherry Picked This patchset was cherry picked to change: Ifd33c5130c383f3afc3e5e6d80c1be017f25ec5b