Review main Merged

12844[BUGFIX] Two mailforms on a page cause error on field validation

Ernesto Baschny CR +2 V +2 Easy +29 −7 updated 07/22/13, 11:14

Commit message

Check formname for uniqueness and if need append a unique hash.

Review

  • Code review CR +2
    • Wouter Wolters +2
  • Verified V +2
    • Wouter Wolters +2

Files 2

Review log 24

  1. Stefan Neufeind commented on patch set 1 05/27/13, 17:19

    Looks good to me, but someone else must approve looks trivial but useful to have
  2. Stefan Neufeind uploaded patch set 2 05/27/13, 17:19

  3. Stefan Neufeind commented on patch set 2 05/27/13, 17:19

    Looks good to me, but someone else must approve hand-rebased removed one debug()-call from previous patch-set :-)
  4. Stefan Neufeind commented on patch set 3 05/27/13, 17:19

    Looks good to me, but someone else must approve hand-rebased removed one debug()-call from original patch-set :-)
  5. Stefan Neufeind uploaded patch set 3 05/27/13, 17:19

  6. Stefan Neufeind uploaded patch set 4 05/27/13, 17:19

  7. Stefan Neufeind commented on patch set 4 05/27/13, 17:19

    The getUniqueId()-function already contained a check for a non-set formName, so we can make use of that as well. Moved that part over. Also took care of adding a description and the Releases-line to commit-msg.
  8. Alexander Opitz commented on patch set 3 05/27/13, 17:19

    I would prefer that you didn't submit this Looks good to me, please fix the small hints so we get this ready.
    Can you add a short description of what you do to fix the problem?
    The right order would be 6.1, 6.0, 4.7, 4.5
  9. Alexander Opitz commented on patch set 4 05/27/13, 17:19

    Looks good to me, but someone else must approve
  10. Jigal van Hemert commented on patch set 3 05/27/13, 17:19

    Verified; I would prefer that you didn't submit this Please fix commit message (describe what it does instead of the bug report title; proper version list). If I have the time available I'll push an updated patch.
  11. Mr. Jenkins commented on patch set 1 05/27/13, 17:19

  12. Mr. Jenkins commented on patch set 2 05/27/13, 17:19

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/6858/ : FAILURE
  13. Mr. Jenkins commented on patch set 3 05/27/13, 17:19

  14. Mr. Jenkins commented on patch set 4 05/27/13, 17:19

  15. Stefan Neufeind commented on patch set 4 CR +1 07/19/13, 09:45

    6.2, 6.1, 6.0, 4.5
  16. Ernesto Baschny updated the commit message in patch set 4 07/21/13, 21:05

  17. Mr. Jenkins commented on patch set 5 07/21/13, 21:06

  18. Stefan Neufeind commented on patch set 5 V +1 CR +1 07/21/13, 23:03

    old form-functionality. To test disable extension "form" you might have installed.
  19. Wouter Wolters uploaded patch set 6 07/22/13, 11:12

  20. Wouter Wolters commented on patch set 6 V +2 CR +2 07/22/13, 11:13

    Only rebased, merged with previous votes taken into account
  21. Wouter Wolters merged patch set 7 07/22/13, 11:13

  22. Wouter Wolters commented on patch set 7 07/22/13, 11:13

    Cherry Picked This patchset was cherry picked to change: Ifd33c5130c383f3afc3e5e6d80c1be017f25ec5b
  23. Mr. Jenkins commented on patch set 6 07/22/13, 11:13

  24. Wouter Wolters commented on patch set 7 07/22/13, 11:14

    Cherry Picked This patchset was cherry picked to change: Ifd33c5130c383f3afc3e5e6d80c1be017f25ec5b