12867[BUGFIX] Send sane HTTP response in showpic on error
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Mario Rimann +1
- Anja Leichsenring +1
- Marcus Krause +1
- Ernesto Baschny +1
-
Verified V +2
- Christian Kuhn +2
- Anja Leichsenring +1
- Marcus Krause +1
Files 2
Review log 10
-
Ernesto Baschny commented on patch set 1 07/20/12, 09:56
Looks good to me, but someone else must approve -
Mario Rimann commented on patch set 1 07/20/12, 09:56
Looks good to me, but someone else must approve I guess that the whole header-throwing stuff is not tested/testable with reasonable efforts, right? If not, it would be cool to add tests for the stuff in class.t3lib_utility_http.php -
Christian Kuhn commented on patch set 1 07/20/12, 09:56
Hint on testing: Just call showpic.php with some broken parameter, example below. Chrome will deliver a happy error message, and firefox with firebug will also show the 410 response. http://www.domain.foo/?eID=tx_cms_showpic&file=uploads%2Ftx_foo%2Faoeu.jpg&md5=7ec23ea567813281234569acb0e24347adfb8645¶meters0=YoeuntzOjU6IndpZHRoIjtzOjQ6Ijc3MG0iO3M6NzoiYm9keVRhZyI7czo2ODoi¶meters1=PGJvZHkgbGVmdG1hcmdpbj0iMCIgdG9wbWFyZ2lIwIiBtYXJnaW53aWR0aD0i¶meters2=MCIgbWFyZ2luaGVpZ2h0PSIwIj4iO3M6NDoid3I7czozNToiPGEgaHJlZj0i¶meters3=amF2YXNjcmlwjbG9zZSgpOyI%2BfDwvYT4iO30%3D -
Christian Kuhn commented on patch set 1 07/20/12, 09:56
We actually tried to add a test for the setResponseCode method, but were unable to find a working solution with ob_start, headers_list and so on. Especially headers_list() doesn't seem to always give back useful results and it seems to depend on the SAPI and maybe other things. We dropped the test after nearly an hour of fiddling again. -
Marcus Krause commented on patch set 1 07/20/12, 09:56
Verified; Looks good to me, but someone else must approve patch is running on a live server; no more flodding of the BE log and crawlers who respect the HTTP codes; +1 for core integration -
Anja Leichsenring voted on patch set 1 V 0 07/20/12, 09:56
-
Anja Leichsenring commented on patch set 1 07/20/12, 09:56
Looks good to me, but someone else must approve -
Mr. Jenkins commented on patch set 1 07/20/12, 09:56
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/4912/ : SUCCESS -
Christian Kuhn commented on patch set 1 V 0 07/20/12, 09:56
by team member; Looks good to me, approved -
Christian Kuhn merged patch set 1 07/20/12, 09:56