Review main Merged

1288[BUGFIX] CSH not showing "more info" link icon anymore

Steffen Kamper CR +2 V +2 Easy +3 −2 updated 06/03/13, 20:49

Commit message

With the missing link icon it's not clear that there is more info on click.
This cahnge brings back the icon to the tooltip.

Review

  • Code review CR +2
    • Francois Suter +2
    • Steffen Gebert +1
  • Verified V +2
    • Francois Suter +2
    • Steffen Gebert +1

Files 1

Review log 10

  1. Francois Suter commented on patch set 2 V 0 03/28/11, 18:45

    by team member; Looks good to me, approved Works beautifully, thanks a lot. Don't forget to apply the change to 4.5 too. I must say I just wonder why it worked before...
  2. Steffen Gebert commented on patch set 2 03/28/11, 18:45

    Verified; Looks good to me, but someone else must approve

    class.extdirect_dataprovider_contexthelp.php:94

    This *removes* the line break.
  3. Steffen Gebert commented on patch set 2 03/28/11, 18:45

    I think it never worked before. The CSH in TCEforms works pretty much totally different than in other places (where a <p> tag is outputted from the DataProvider).
  4. Steffen Gebert commented on patch set 2 03/28/11, 18:45

    (1 inline comment)
  5. Steffen Gebert commented on patch set 2 03/28/11, 18:45

    I think it never worked before. The CSH in TCEforms works pretty much totally different than in other places (where a <p> tag is outputted from the DataProvider).
  6. Steffen Gebert uploaded patch set 2 03/28/11, 18:45

  7. Steffen Gebert merged patch set 2 03/28/11, 18:45

  8. Mr. Jenkins commented on patch set 1 03/28/11, 18:45

  9. Mr. Jenkins commented on patch set 2 03/28/11, 18:45

  10. Steffen Gebert commented on patch set 2 03/28/11, 18:45

    Sorry.. while commenting I had the other CSH issue in mind ( I65c1312761b852f53826db5b477db3c645a9445f) But maybe it's the same here that it never worked for the TCEforms CSH.