Review main Merged

12903[TASK] Deprecate IconUtility::getIconImage

Wouter Wolters CR +2 V +2 Easy +3 −0 updated 06/03/13, 20:49

Commit message

IconUtility::getIconImage
is not used anymore in the core, so deprecated this function.

Review

  • Code review CR +2
    • Benni Mack +2
    • Nicole Hummel +1
  • Verified V +2
    • Benni Mack +2
    • Nicole Hummel +1

Issues 1

Files 1

Review log 21

  1. Ernesto Baschny commented on patch set 1 04/08/13, 06:45

    (1 inline comment)

    class.t3lib_iconworks.php:131

    For more compatibility, you could also pass the parsed $params as $options to the getSpriteIconForRecord, so that stuff like "title=xxx" still work while the method is not replaced on all extensions. Isn't there any replacement for the $dim (grayed out icon) in the sprites? Probably by setting some kind of class?
  2. Christian Kuhn commented on patch set 2 04/08/13, 06:45

    I would prefer that you didn't submit this The method is still used in ext:version. Please do not deprecate until core and core extensions are clean. Furthermore I do not really understand the fallback. Usually methods stay as they are (except there are good reasons not to do) if they are deprecated. You change the code to use some other 'shaded' icon instead. I don't really understand the impact ...
  3. Steffen Ritter uploaded patch set 2 04/08/13, 06:45

  4. Felix Kopp commented on patch set 2 04/08/13, 06:45

    Should getIconImage be deprecated or not?
  5. Mr. Jenkins commented on patch set 1 04/08/13, 06:45

  6. Mr. Jenkins commented on patch set 2 04/08/13, 06:45

  7. Wouter Wolters commented on patch set 1 04/08/13, 06:45

    (1 inline comment)

    class.t3lib_iconworks.php:131 Reply

    $params is a string and in getSpriteIconForRecord $options is an array. So we cannot just pass it through. I had a look for the grayed out icon but did not find any class for that.
  8. Wouter Wolters commented on patch set 2 04/08/13, 06:45

    Looks good to me, but someone else must approve
  9. Mr. Jenkins commented on patch set 3 04/08/13, 06:45

  10. Wouter Wolters uploaded patch set 3 04/08/13, 06:45

  11. Benni Mack uploaded patch set 5 04/08/13, 06:45

  12. Steffen Ritter commented on patch set 4 04/08/13, 06:45

    Verified; Looks good to me, but someone else must approve
  13. Mr. Jenkins commented on patch set 4 04/08/13, 06:45

  14. Mr. Jenkins commented on patch set 5 04/08/13, 06:45

  15. Wouter Wolters uploaded patch set 4 04/08/13, 06:45

  16. Benni Mack commented on patch set 6 V 0 04/08/13, 06:45

    by team member; Looks good to me, approved
  17. Mr. Jenkins commented on patch set 6 04/08/13, 06:45

  18. Nicole Hummel commented on patch set 6 04/08/13, 06:45

    Just added the version were the function could be removed.
  19. Nicole Hummel commented on patch set 6 04/08/13, 06:45

    Verified; Looks good to me, but someone else must approve
  20. Nicole Hummel uploaded patch set 6 04/08/13, 06:45

  21. Benni Mack merged patch set 7 04/08/13, 06:45