Review TYPO3_4-5 Merged

1291[BUGFIX] sys_action: Fix Record List page switching

Thomas Maroschik CR +2 V +2 Normal +101 −2 updated 06/03/13, 20:49

Commit message

If a list-records-task lists more than 100 records, the singe table page turning
functionality is shown on top of the table. If you want to switch the page (or
enter a page number) nothing happens or you get elsewhere than you are supposed
to be.

This happens due to wrong link generation. The Listmodule has been refactored, but the
sys_actions Module stayed the same. Link generation was broken.

This patch fixes the issues with sys_actions and list link generation by subclassing
the localRecordList class and adopting the link generation to sys_actions needs.

Review

  • Code review CR +2
    • Steffen Gebert +2
  • Verified V +2
    • Steffen Gebert +2

Issues 1

Files 3

Review log 24

  1. Stefan Neufeind commented on patch set 3 06/29/11, 19:17

    Looks good to me, but someone else must approve
  2. Georg Ringer commented on patch set 3 06/29/11, 19:17

    Verified; Looks good to me, but someone else must approve
  3. Steffen Gebert uploaded patch set 3 06/29/11, 19:17

  4. Steffen Gebert commented on patch set 3 06/29/11, 19:17

    Thanks for your patch, Thomas! I've adjusted the commit message and CGL a bit. Please push also for master, to not forget this change for newer releases.
  5. Steffen Gebert commented on patch set 3 V 0 06/29/11, 19:17

    by team member; Looks good to me, but someone else must approve
  6. Steffen Gebert commented on patch set 3 06/29/11, 19:17

    Verified; Looks good to me, approved
  7. Thomas Maroschik uploaded patch set 2 06/29/11, 19:17

  8. Philipp Gampe commented on patch set 3 06/29/11, 19:17

    Verified; Looks good to me, but someone else must approve
  9. Stefan Neufeind commented on patch set 4 06/29/11, 19:17

    Looks good to me, but someone else must approve
  10. Georg Ringer commented on patch set 4 06/29/11, 19:17

    Verified; Looks good to me, but someone else must approve
  11. Steffen Gebert uploaded patch set 5 06/29/11, 19:17

  12. Kay Strobach commented on patch set 4 06/29/11, 19:17

    Verified; Looks good to me, but someone else must approve
  13. Thomas Maroschik commented on patch set 4 06/29/11, 19:17

    Verified; Looks good to me, but someone else must approve
  14. Philipp Gampe uploaded patch set 4 06/29/11, 19:17

  15. Philipp Gampe commented on patch set 4 06/29/11, 19:17

    Verified; Looks good to me, but someone else must approve no changes, just rebased please renew your vote
  16. Fabien Udriot commented on patch set 3 06/29/11, 19:17

    Looks good to me, but someone else must approve
  17. Fabien Udriot commented on patch set 4 06/29/11, 19:17

    Looks good to me, but someone else must approve
  18. Mr. Jenkins commented on patch set 1 06/29/11, 19:17

  19. Mr. Jenkins commented on patch set 2 06/29/11, 19:17

  20. Mr. Jenkins commented on patch set 3 06/29/11, 19:17

  21. Mr. Jenkins commented on patch set 4 06/29/11, 19:17

  22. Mr. Jenkins commented on patch set 5 06/29/11, 19:17

  23. Steffen Gebert commented on patch set 5 V 0 06/29/11, 19:17

    by team member; Looks good to me, approved Just updated the commit message to use the forge-id (not the old one from mantis). Submitted after enough votes.
  24. Steffen Gebert merged patch set 5 06/29/11, 19:17