Review TYPO3_4-6 Abandoned

13019[BUGFIX] Make alphabetic filter work with umlauts

Mario Rimann CR 0 V 0 Normal +78 −1 updated 06/03/13, 20:49

Commit message

Changes the regular expression used to validate the string into a
unicode-aware character-class and adds two testcases for this.

Review

  • Code review CR 0
  • Verified V 0

Files 2

Review log 6

  1. Mario Rimann uploaded patch set 2 03/01/13, 11:11

  2. Mario Rimann commented on patch set 2 03/01/13, 11:11

    Patchset 2 incorporates the requested change and rebases the change to the current TYPO3_4-6 branch.
  3. Stefan Neufeind commented on patch set 1 03/01/13, 11:11

    I would prefer that you didn't submit this

    Alphabetic.php:71

    merged in 4.7 with: $pattern = '/[^\pL' . $whiteSpace . ']/u'; Please update patch according to what was merged in 4.7.

    AlphabeticTest.php:6

    whitespace
  4. Stefan Neufeind commented on patch set 2 1 comment 03/01/13, 11:11

    Looks good to me, but someone else must approve comparing with 4.7 which is already merged I think this should be fine (expect the whitespace-issue)
  5. Mattias Nilsson commented on patch set 2 03/01/13, 11:11

    Looks good to me, but someone else must approve
  6. Oliver Hader commented on patch set 2 03/01/13, 11:11

    Abandoned TYPO3 4.6 branch is at the end of bug fixing period. Only priority changes will be considered (compatibility fixes and security fixes) until end of April 2013.