Review TYPO3_4-5 Merged

1304[BUGFIX] Wrong display of csh icon and text in new record wizard

Sebastian Müller CR +2 V +2 Easy +1 −1 updated 06/03/13, 20:49

Commit message

For each TCA-Table where you can add an element on a side, there is displayed
a csh icon with text (if text is configured). In db_new.php is a wrong
variable used so the csh text of the last tca-table is always used and for
each table. So it will also be displayed for tables which orginally got no csh text.

Additionally due to a missing break, the csh icon of a table is displayed
in the wrong line.

Review

  • Code review CR +2
    • Francois Suter +2
    • Susi Moog +1
  • Verified V +2
    • Francois Suter +2
    • Susi Moog +1

Issues 1

Files 1

Review log 6

  1. Francois Suter commented on patch set 2 V 0 04/03/11, 19:24

    by team member; Looks good to me, approved Perfectly right.
  2. Susi Moog uploaded patch set 2 04/03/11, 19:24

  3. Susi Moog commented on patch set 2 04/03/11, 19:24

    Verified; Looks good to me, but someone else must approve
  4. Mr. Jenkins commented on patch set 1 04/03/11, 19:24

  5. Mr. Jenkins commented on patch set 2 04/03/11, 19:24

  6. Francois Suter merged patch set 2 04/03/11, 19:24