Review main Merged

13082[BUGFIX] BEfunc getProcessedValue doesn't show record title for "group"

Benni Mack CR +2 V +2 Normal +51 −1 updated 06/03/13, 20:49

Commit message

In the list view relation fields using the type group (internal_type=db)
doesn't display the related value as expected. Instead, it shows
the UID of the relation. As these calls go through getProcessedValue,
the issue resolves the records by displaying the record titles correctly
in the TYPO3 backend.

Review

  • Code review CR +2
    • Wouter Wolters +2
  • Verified V +2
    • Wouter Wolters +2

Issues 1

Files 2

Review log 25

  1. Georg Ringer commented on patch set 1 05/05/13, 13:16

    Verified; Looks good to me, but someone else must approve
  2. Mr. Jenkins commented on patch set 1 05/05/13, 13:16

  3. Benni Mack uploaded patch set 3 05/05/13, 13:16

  4. Benni Mack uploaded patch set 4 05/05/13, 13:16

  5. Benni Mack uploaded patch set 5 05/05/13, 13:16

  6. Alexander Opitz commented on patch set 4 05/05/13, 13:16

    I would prefer that you didn't submit this

    BackendUtility.php:2010

    False indentation

    BackendUtility.php:2018

    You should switch to not negate boolean
  7. Alexander Opitz commented on patch set 5 05/05/13, 13:16

    Looks good to me, but someone else must approve
  8. Mr. Jenkins commented on patch set 2 05/05/13, 13:16

  9. Mr. Jenkins commented on patch set 3 05/05/13, 13:16

  10. Mr. Jenkins commented on patch set 4 05/05/13, 13:16

  11. Mr. Jenkins commented on patch set 5 05/05/13, 13:16

  12. Wouter Wolters commented on patch set 2 05/05/13, 13:16

    Looks good to me, but someone else must approve Removed tabs, no codewise changes. Please reaplly vote
  13. Wouter Wolters uploaded patch set 2 05/05/13, 13:16

  14. Mr. Jenkins commented on patch set 6 05/05/13, 13:16

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/8663/ : FAILURE
  15. Nicole Hummel commented on patch set 6 05/05/13, 13:16

    Verified; Looks good to me, but someone else must approve Added unit tests for group processing
  16. Nicole Hummel uploaded patch set 6 05/05/13, 13:16

  17. Alexander Opitz commented on patch set 7 05/05/13, 13:16

    Verified; Looks good to me, but someone else must approve
  18. Philipp Gampe commented on patch set 7 05/05/13, 13:16

    Verified; Looks good to me, but someone else must approve
  19. Mr. Jenkins commented on patch set 7 05/05/13, 13:16

  20. Mr. Jenkins commented on patch set 8 05/05/13, 13:16

  21. Wouter Wolters uploaded patch set 8 05/05/13, 13:16

  22. Nicole Hummel commented on patch set 7 05/05/13, 13:16

    Verified; Looks good to me, but someone else must approve As I haven't added the functionality I can vote for this patch as well
  23. Nicole Hummel uploaded patch set 7 05/05/13, 13:16

  24. Wouter Wolters commented on patch set 8 V 0 05/05/13, 13:16

    by team member; Looks good to me, approved Rebased, previous votes still valid
  25. Wouter Wolters merged patch set 9 05/05/13, 13:16