1317[TASK] PHP closing tag don't exist in some files
Commit message
Review
-
Code review CR +2
- Ernesto Baschny +2
-
Verified V +2
- Ernesto Baschny +2
Issues 1
Files 12
- t3lib/interfaces/tree/interface.t3lib_tree_comparablenode.php+1 −0
- t3lib/interfaces/tree/interface.t3lib_tree_draggableanddropable.php+1 −0
- t3lib/interfaces/tree/interface.t3lib_tree_labeleditable.php+1 −0
- t3lib/utility/dependency/class.t3lib_utility_dependency_callback.php+1 −0
- t3lib/utility/dependency/class.t3lib_utility_dependency_element.php1+2 −1
- t3lib/utility/dependency/class.t3lib_utility_dependency_factory.php+1 −0
- t3lib/utility/dependency/class.t3lib_utility_dependency_reference.php1+2 −1
- typo3/sysext/cms/tslib/hooks/class.tx_cms_fehooks.php1+2 −1
- typo3/sysext/em/interfaces/interface.tx_em_renderhook.php1+2 −1
- typo3/sysext/scheduler/class.tx_scheduler_croncmd.php+1 −0
- typo3/sysext/workspaces/Classes/ExtDirect/ToolbarMenu.php1+2 −1
- typo3/sysext/workspaces/Classes/Service/Fehooks.php+1 −0
Review log 9
-
Ernesto Baschny commented on patch set 2 V 0 03/30/11, 07:48
by team member; Looks good to me, approved No brainer, and I checked that the closing braces are ok. Thanks for your contribution! -
Ernesto Baschny uploaded patch set 2 03/30/11, 07:48
-
Björn Pedersen commented on patch set 1 03/30/11, 07:48
Looks good to me, but someone else must approve In the gitweb interface the changes look OK. The braces are there marked as - } /+}, so no additional brace. -
Markus Klein commented on patch set 1 03/30/11, 07:48
Looks good to me, but someone else must approve When I use the patch URL to view the patch on my machine everything is alright. I converted my -1 to +1. The problem seems to be, that there's no newline at the end of the file, example of the patch output: --- a/t3lib/utility/dependency/class.t3lib_utility_dependency_element.php +++ b/t3lib/utility/dependency/class.t3lib_utility_dependency_element.php @@ -313,4 +313,5 @@ class t3lib_utility_Dependency_Element { public static function getIdentifier($table, $id) { return $table . ':' . $id; } -} \ No newline at end of file +} +?> \ No newline at end of fileclass.t3lib_utility_dependency_element.php:316One closing brace too much?class.t3lib_utility_dependency_reference.php:79One closing brace too much?class.tx_cms_fehooks.php:64One closing brace too much?interface.tx_em_renderhook.php:38One closing brace too much?ToolbarMenu.php:64One closing brace too much? -
Markus Klein commented on patch set 1 5 comments 03/30/11, 07:48
I would prefer that you didn't submit this Good catch, but please push a corrected version of this change. -
Stefano Kowalke commented on patch set 1 03/30/11, 07:48
I stumpled over this too. In the IDE it looks normal - no double brace. In Git tool it looks like the old brace was removed by a new one. Very strange. Anyway, I forgot the bug reference an will upload a new patchset. -
Mr. Jenkins commented on patch set 1 03/30/11, 07:48
Build Successful SUCCESS: http://ci.typo3.org/job/typo3-v4-core-gerrit/138/ -
Mr. Jenkins commented on patch set 2 03/30/11, 07:48
Build Successful SUCCESS: http://ci.typo3.org/job/typo3-v4-core-gerrit/140/ -
Ernesto Baschny merged patch set 2 03/30/11, 07:48