Review main Merged

1317[TASK] PHP closing tag don't exist in some files

Stefano Kowalke CR +2 V +2 Easy +17 −5 updated 06/03/13, 20:49

Commit message

Review

  • Code review CR +2
    • Ernesto Baschny +2
  • Verified V +2
    • Ernesto Baschny +2

Issues 1

Files 12

Review log 9

  1. Ernesto Baschny commented on patch set 2 V 0 03/30/11, 07:48

    by team member; Looks good to me, approved No brainer, and I checked that the closing braces are ok. Thanks for your contribution!
  2. Ernesto Baschny uploaded patch set 2 03/30/11, 07:48

  3. Björn Pedersen commented on patch set 1 03/30/11, 07:48

    Looks good to me, but someone else must approve In the gitweb interface the changes look OK. The braces are there marked as - } /+}, so no additional brace.
  4. Markus Klein commented on patch set 1 03/30/11, 07:48

    Looks good to me, but someone else must approve When I use the patch URL to view the patch on my machine everything is alright. I converted my -1 to +1. The problem seems to be, that there's no newline at the end of the file, example of the patch output: --- a/t3lib/utility/dependency/class.t3lib_utility_dependency_element.php +++ b/t3lib/utility/dependency/class.t3lib_utility_dependency_element.php @@ -313,4 +313,5 @@ class t3lib_utility_Dependency_Element { public static function getIdentifier($table, $id) { return $table . ':' . $id; } -} \ No newline at end of file +} +?> \ No newline at end of file

    class.t3lib_utility_dependency_element.php:316

    One closing brace too much?

    class.t3lib_utility_dependency_reference.php:79

    One closing brace too much?

    class.tx_cms_fehooks.php:64

    One closing brace too much?

    interface.tx_em_renderhook.php:38

    One closing brace too much?

    ToolbarMenu.php:64

    One closing brace too much?
  5. Markus Klein commented on patch set 1 5 comments 03/30/11, 07:48

    I would prefer that you didn't submit this Good catch, but please push a corrected version of this change.
  6. Stefano Kowalke commented on patch set 1 03/30/11, 07:48

    I stumpled over this too. In the IDE it looks normal - no double brace. In Git tool it looks like the old brace was removed by a new one. Very strange. Anyway, I forgot the bug reference an will upload a new patchset.
  7. Mr. Jenkins commented on patch set 1 03/30/11, 07:48

  8. Mr. Jenkins commented on patch set 2 03/30/11, 07:48

  9. Ernesto Baschny merged patch set 2 03/30/11, 07:48