1318[BUGFIX] Installation from own TER not possible
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 5
Review log 48
Show 23 earlier messages
-
Ernesto Baschny commented on patch set 1 01/30/13, 22:07
Fails; I would prefer that you didn't submit this Same problem as noticed in the 4.5 review: https://review.typo3.org/1319 Suggestion: finish the "master" issue first and back-port to 4.5 when it's ready. -
Steffen Kamper commented on patch set 2 01/30/13, 22:07
Now the combo in repository list also change the selected repository, so either switch in settings or in repository list. -
Steffen Kamper uploaded patch set 2 01/30/13, 22:07
-
Ernesto Baschny commented on patch set 3 01/30/13, 22:07
Fails; Do not submit Ignore patch set 3, this is meant to review 1319 (TYPO3_4-5). I will re-submit in a second -
Mario Rimann commented on patch set 3 01/30/13, 22:07
Any news on this issue/review? -
Steffen Kamper uploaded patch set 3 01/30/13, 22:07
-
Mr. Jenkins commented on patch set 1 01/30/13, 22:07
Build Successful SUCCESS: http://ci.typo3.org/job/typo3-v4-core-gerrit/139/ -
Mr. Jenkins commented on patch set 2 01/30/13, 22:07
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/533/ : SUCCESS -
Mr. Jenkins commented on patch set 3 01/30/13, 22:07
Fails; I would prefer that you didn't submit this Build Failed http://ci.typo3.org/job/typo3-v4-core-gerrit/535/ : FAILURE -
Xavier Perseguers commented on patch set 4 01/30/13, 22:07
I would prefer that you didn't submit this Preparing another patch as this one cannot be applied. Still, I'll have a question to be answered for the inline comment.class.tx_em_tools_xmlhandler.php:144Please add code in the rest of EM code to use this additional setting. I could not find a clever way of accessing the settings from this class with the previous patch and it sounded like a shift of responsibility. So I'd say that an additional parameter is better suited.class.tx_em_tools_xmlhandler.php:172Don't know where this $emObj comes from. -
Xavier Perseguers uploaded patch set 5 01/30/13, 22:07
-
Xavier Perseguers commented on patch set 5 1 comment 01/30/13, 22:07
Fails See comment, fix is not complete -
Mr. Jenkins commented on patch set 4 01/30/13, 22:07
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2073/ : SUCCESS -
Mr. Jenkins commented on patch set 5 01/30/13, 22:07
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2094/ : SUCCESS -
Wouter Wolters uploaded patch set 4 01/30/13, 22:07
-
Wouter Wolters commented on patch set 4 01/30/13, 22:07
There was a typo in tx_em_Connection_ExtDirectServer class and function getRemoteExtensionList. Changed "selctedRepository" to "selectedRepository" -
Stefan Neufeind uploaded patch set 8 01/30/13, 22:07
-
Stefan Neufeind commented on patch set 8 01/30/13, 22:07
Looks good to me, but someone else must approve fixed whitespaces, updated releases-line looks fine by reading. Unfortunately can't test since I lack access to a TER-repo for testing :-( @Ernesto: Could you please remove your blocker -1? From the history that looks like a leftover. @Wouter: You said you tested it. Could you please give a "verified" then? Which repo did you test with? (Might help others to test if we could have a small test-repo again.) -
Oliver Hader uploaded patch set 7 01/30/13, 22:07
-
Oliver Hader commented on patch set 7 01/30/13, 22:07
Do not submit Rebasing to master V:0, R:-2 V:0, R:-2 from Ernesto Baschny <ernst@cron-it.de> -
Philipp Gampe commented on patch set 8 01/30/13, 22:07
Fails I am investigating. -
Philipp Gampe uploaded patch set 9 01/30/13, 22:07
-
Ernesto Baschny commented on patch set 10 01/30/13, 22:07
No score I remove my -2 for now to avoid being "in the way", as many time has past since anyway. Thanks for taking care!
-
Stefan Neufeind commented on patch set 10 01/30/13, 22:07
@Ernesto: if I read the history right, could you please remove your blocker on this review? -
Stefan Neufeind commented on patch set 10 V 0 01/30/13, 22:07
I was able to add the test-TER, could search and also saw author "Test". After downloading the ext and checking the author again it wasn't Test anymore. But Wireshark showed TYPO3 pulled from the correct server. So I assume that t3x was just not updated as well. So it looks like with this patch installing from an own TER worked fine for me. -
Stefan Neufeind commented on patch set 10 01/30/13, 22:07
Looks good to me, but someone else must approve -
Stefan Neufeind commented on patch set 10 01/30/13, 22:07
Since 6.0 has a new extension-manager now, do I assume right it's just relevant for 4.5 to 4.7 now? If so, could somebody please take over the task of a final review, submit it to the other branches and finish the review? -
Christian Kuhn commented on patch set 10 01/30/13, 22:07
Fails; I would prefer that you didn't submit this no, this will *not* be implebmented for 4.7 anymore: The effort to review is way to high and it is likely to break something. pleas do not merge anymore, please abandon and close issue as 'won't fix'. -
Christian Weiske commented on patch set 10 01/30/13, 22:07
Verified; Looks good to me, but someone else must approve I can import extensions from the main repository and the additional repository now! That feature finally works. -
Philipp Gampe commented on patch set 10 V 0 01/30/13, 22:07
I fixed a whitespace issue (indent with space instead of tab). Also, I changed the !isset($settings['selectedMirror']) to empty(..) because for me this key was set (*). (*) I think this is another bug, because I can not set any other mirror than random. Really said, that the code for such a vital part of TYPO3 is so crappy ... not fun to debug :( Also I took forever to tell the EM to search in the Test Repo, it was keeping to search in the TYPO3.org TER. At some point I figured out that I have to first search in T3o TER and then switch to the Test TER. Once I got that it started magically to work, so I could search in the selected TER ?!? (*WAT*) -
Philipp Gampe uploaded patch set 10 01/30/13, 22:07
-
Philipp Gampe commented on patch set 10 01/30/13, 22:07
Looks good to me, but someone else must approve Well, I did have a look at the code ;) -
Philipp Gampe commented on patch set 10 01/30/13, 22:07
No time today to rebase this, it should be included in 6.0 or must be pushed to the other branches. @Ernesto, please review again -
Philipp Gampe commented on patch set 10 01/30/13, 22:07
Please do not forget to adjust the releases line before merging. -
Mr. Jenkins commented on patch set 6 01/30/13, 22:07
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2131/ : SUCCESS -
Mr. Jenkins commented on patch set 7 01/30/13, 22:07
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2696/ : SUCCESS -
Mr. Jenkins commented on patch set 8 01/30/13, 22:07
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/3159/ : SUCCESS -
Mr. Jenkins commented on patch set 9 01/30/13, 22:07
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/3178/ : SUCCESS -
Mr. Jenkins commented on patch set 10 01/30/13, 22:07
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/3179/ : SUCCESS -
Wouter Wolters uploaded patch set 6 01/30/13, 22:07
-
Wouter Wolters commented on patch set 7 01/30/13, 22:07
I just tested this patch against master. Still working. -
Wouter Wolters commented on patch set 8 01/30/13, 22:07
Added some extra info in Forge regarding a "test" repository. -
Wouter Wolters commented on patch set 8 01/30/13, 22:07
Verified; Looks good to me, but someone else must approve -
Wouter Wolters commented on patch set 8 01/30/13, 22:07
@Stefan I will publish a demo repository this evening -
Wouter Wolters commented on patch set 10 01/30/13, 22:07
Reminder:-) -
Wouter Wolters commented on patch set 10 01/30/13, 22:07
Verified; Looks good to me, but someone else must approve I agree it is not fun to debug this part of TYPO3. What you encountered with selecting the correct repository is another bug in my opinion. I figured out that the selector in "Import Extensions" and the selector in "Settings" are saving their value in the same setting variable. -
Wouter Wolters commented on patch set 10 01/30/13, 22:07
Fails; I would prefer that you didn't submit this Not working in master. New EM:-) If someone is still interested in this patch then please backport it to 4.7 for the old EM. -
Christian Kuhn commented on patch set 10 01/30/13, 22:07
Abandoned abandoned: this issue will not be solved in typo3 <= 4.7 with 'old' em anymore.