Review main Abandoned

13533[FEATURE] respect BOX dimensions in gifbuilder size calculation

Kjeld Schumacher CR 0 V 0 Easy +13 −6 updated 06/03/13, 20:49

Commit message

Add support for calculating the image size by using BOX width
and height dimensions.

Review

  • Code review CR 0
  • Verified V 0

Files 7

Review log 9

  1. Mr. Jenkins commented on patch set 1 02/03/13, 20:41

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/5190/ : FAILURE
  2. Georg Ringer commented on patch set 2 02/03/13, 20:41

    Looks good to me, but someone else must approve would be nice to get to know how this can be tested
    this must be 6.0
  3. Georg Ringer commented on patch set 2 1 comment 02/03/13, 20:41

    I would prefer that you didn't submit this
  4. Mr. Jenkins commented on patch set 2 02/03/13, 20:41

  5. Kjeld Schumacher uploaded patch set 2 02/03/13, 20:41

  6. Georg Ringer commented on patch set 3 02/03/13, 20:41

    I would prefer that you didn't submit this please remove the submodule pointers
  7. Mr. Jenkins commented on patch set 3 02/03/13, 20:41

  8. Kjeld Schumacher uploaded patch set 3 02/03/13, 20:41

  9. Christian Kuhn commented on patch set 3 02/03/13, 20:41

    Abandoned abandoned. duplicate of https://review.typo3.org/#/c/13564/