13598[BUGFIX] Page module title obeys language overlay
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Pascal Dürsteler +1
- Anja Leichsenring +1
-
Verified V +2
- Christian Kuhn +2
- Pascal Dürsteler +1
- Anja Leichsenring +1
Issues 1
Files 1
Review log 25
-
Felix Kopp uploaded patch set 2 04/05/13, 19:28
-
Felix Kopp commented on patch set 2 04/05/13, 19:28
Could be unifies with https://review.typo3.org/#/c/13599/ -
Felix Kopp commented on patch set 2 04/05/13, 19:28
This patch is easily reviewed. Open a subpage in page backend module and look at the bold title. The title is localized now. -
Dmitry Dulepov commented on patch set 3 04/05/13, 19:28
I would prefer that you didn't submit this I am not sure I like this. Page tree shows one title and in the page module you get something totally different. It causes questions ("Do I see a proper page?"). This is not a blocking -1 and can be overruled. I just think that usability suffers here. -
Helmut Hummel commented on patch set 3 04/05/13, 19:28
I would prefer that you didn't submit this I agree with Dmitry here. This change makes sense, if we have the possibilty to have a translated pagetree. Then the title should be shown in the same language as used in the tree. In any case, I'd like to discuss this a bit further, maybe during a UX code sprint or even week, but certainly not before 6.0 release.PageLayoutController.php:493We agreed to not indent inline comments any more since 6.0 -
Felix Kopp commented on patch set 3 04/05/13, 19:28
Hello team, just a quick response I do not agree. I personally don't think that should be harder to mentally abstract the page content from the frontend within the backend just because be have a missing feature in the pagetree. Anyways it is certainly perfectly okay to postpon and I still thank you for your time to review and comments :)) 6.1, 6.1, 6.1 -
Felix Kopp uploaded patch set 3 04/05/13, 19:28
-
Felix Kopp commented on patch set 3 04/05/13, 19:28
Completely new patch obeying namespace changes. Pick me! -
Felix Kopp commented on patch set 3 04/05/13, 19:28
Pick meeee, please! -
Felix Kopp uploaded patch set 4 04/05/13, 19:28
-
Felix Kopp commented on patch set 4 04/05/13, 19:28
Please review and rate positively -
Mattias Nilsson commented on patch set 4 04/05/13, 19:28
Looks good to me, but someone else must approve -
Anja Leichsenring commented on patch set 3 04/05/13, 19:28
Verified; Looks good to me, but someone else must approve works fine after resolving a merge conflict around line 465 (the indention of comments) -
Anja Leichsenring uploaded patch set 5 04/05/13, 19:28
-
Anja Leichsenring commented on patch set 6 04/05/13, 19:28
Verified; Looks good to me, but someone else must approve just a little nitpick solved (why retrieve all fields from pages_language_overlay, when only title is used). I like the patch, after it is in line with the rest of the page module display. This shows the localized content, so the title should imho follow suit. -
Anja Leichsenring uploaded patch set 6 04/05/13, 19:28
-
Pascal Dürsteler commented on patch set 6 04/05/13, 19:28
Verified; Looks good to me, but someone else must approve -
Mr. Jenkins commented on patch set 2 04/05/13, 19:28
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/5217/ : SUCCESS -
Mr. Jenkins commented on patch set 3 04/05/13, 19:28
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/5810/ : SUCCESS -
Mr. Jenkins commented on patch set 4 04/05/13, 19:28
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/6987/ : SUCCESS -
Mr. Jenkins commented on patch set 5 04/05/13, 19:28
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7558/ : SUCCESS -
Mr. Jenkins commented on patch set 6 04/05/13, 19:28
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7559/ : SUCCESS -
Wouter Wolters commented on patch set 3 04/05/13, 19:28
Verified; Looks good to me, but someone else must approve Nice one:) -
Christian Kuhn commented on patch set 6 V 0 04/05/13, 19:28
by team member; Looks good to me, approved -
Christian Kuhn merged patch set 7 04/05/13, 19:28