Review main Merged

13598[BUGFIX] Page module title obeys language overlay

Felix Kopp CR +2 V +2 Easy +26 −2 updated 06/03/13, 20:49

Commit message

Makes the page backend module's headline language overlay aware.

The displayed headline is the page title of the selected page.
But the displayed headline should also consider the selected language.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Pascal Dürsteler +1
    • Anja Leichsenring +1
  • Verified V +2
    • Christian Kuhn +2
    • Pascal Dürsteler +1
    • Anja Leichsenring +1

Issues 1

Files 1

Review log 25

  1. Felix Kopp uploaded patch set 2 04/05/13, 19:28

  2. Felix Kopp commented on patch set 2 04/05/13, 19:28

  3. Felix Kopp commented on patch set 2 04/05/13, 19:28

    This patch is easily reviewed. Open a subpage in page backend module and look at the bold title. The title is localized now.
  4. Dmitry Dulepov commented on patch set 3 04/05/13, 19:28

    I would prefer that you didn't submit this I am not sure I like this. Page tree shows one title and in the page module you get something totally different. It causes questions ("Do I see a proper page?"). This is not a blocking -1 and can be overruled. I just think that usability suffers here.
  5. Helmut Hummel commented on patch set 3 04/05/13, 19:28

    I would prefer that you didn't submit this I agree with Dmitry here. This change makes sense, if we have the possibilty to have a translated pagetree. Then the title should be shown in the same language as used in the tree. In any case, I'd like to discuss this a bit further, maybe during a UX code sprint or even week, but certainly not before 6.0 release.

    PageLayoutController.php:493

    We agreed to not indent inline comments any more since 6.0
  6. Felix Kopp commented on patch set 3 04/05/13, 19:28

    Hello team, just a quick response I do not agree. I personally don't think that should be harder to mentally abstract the page content from the frontend within the backend just because be have a missing feature in the pagetree. Anyways it is certainly perfectly okay to postpon and I still thank you for your time to review and comments :)) 6.1, 6.1, 6.1
  7. Felix Kopp uploaded patch set 3 04/05/13, 19:28

  8. Felix Kopp commented on patch set 3 04/05/13, 19:28

    Completely new patch obeying namespace changes. Pick me!
  9. Felix Kopp commented on patch set 3 04/05/13, 19:28

    Pick meeee, please!
  10. Felix Kopp uploaded patch set 4 04/05/13, 19:28

  11. Felix Kopp commented on patch set 4 04/05/13, 19:28

    Please review and rate positively
  12. Mattias Nilsson commented on patch set 4 04/05/13, 19:28

    Looks good to me, but someone else must approve
  13. Anja Leichsenring commented on patch set 3 04/05/13, 19:28

    Verified; Looks good to me, but someone else must approve works fine after resolving a merge conflict around line 465 (the indention of comments)
  14. Anja Leichsenring uploaded patch set 5 04/05/13, 19:28

  15. Anja Leichsenring commented on patch set 6 04/05/13, 19:28

    Verified; Looks good to me, but someone else must approve just a little nitpick solved (why retrieve all fields from pages_language_overlay, when only title is used). I like the patch, after it is in line with the rest of the page module display. This shows the localized content, so the title should imho follow suit.
  16. Anja Leichsenring uploaded patch set 6 04/05/13, 19:28

  17. Pascal Dürsteler commented on patch set 6 04/05/13, 19:28

    Verified; Looks good to me, but someone else must approve
  18. Mr. Jenkins commented on patch set 2 04/05/13, 19:28

  19. Mr. Jenkins commented on patch set 3 04/05/13, 19:28

  20. Mr. Jenkins commented on patch set 4 04/05/13, 19:28

  21. Mr. Jenkins commented on patch set 5 04/05/13, 19:28

  22. Mr. Jenkins commented on patch set 6 04/05/13, 19:28

  23. Wouter Wolters commented on patch set 3 04/05/13, 19:28

    Verified; Looks good to me, but someone else must approve Nice one:)
  24. Christian Kuhn commented on patch set 6 V 0 04/05/13, 19:28

    by team member; Looks good to me, approved
  25. Christian Kuhn merged patch set 7 04/05/13, 19:28