Review main Merged

13617[FEATURE] Add t3lib_utility_Math::isIntegerInRange

Steffen Gebert CR +2 V +2 Normal +76 −0 updated 06/03/13, 20:49

Commit message

Review

  • Code review CR +2
    • Jigal van Hemert +2
    • Christian Kuhn +1
  • Verified V +2
    • Jigal van Hemert +2
    • Christian Kuhn +1

Issues 1

Files 2

Review log 18

  1. Christian Kuhn commented on patch set 1 08/13/12, 06:55

    I would prefer that you didn't submit this No merge in this area without unit tests ;)

    class.t3lib_utility_mathTest.php:258

    This should be a data provider.
  2. Georg Ringer commented on patch set 1 08/13/12, 06:55

    Verified; Looks good to me, but someone else must approve
  3. Steffen Gebert commented on patch set 1 08/13/12, 06:55

    I would prefer that you didn't submit this Damn, added the tests to the wrong commit ;-)
  4. Steffen Gebert uploaded patch set 2 08/13/12, 06:55

  5. Christian Kuhn commented on patch set 3 08/13/12, 06:55

    (1 inline comment)
  6. Christian Kuhn commented on patch set 3 08/13/12, 06:55

    will push update in some minutes.
  7. Christian Kuhn commented on patch set 4 08/13/12, 06:55

    Verified; Looks good to me, but someone else must approve
  8. Christian Kuhn uploaded patch set 4 08/13/12, 06:55

  9. Steffen Gebert uploaded patch set 3 08/13/12, 06:55

  10. Jigal van Hemert commented on patch set 3 08/13/12, 06:55

    Verified; Looks good to me, but someone else must approve
  11. Jigal van Hemert commented on patch set 4 V 0 08/13/12, 06:55

    by team member; Looks good to me, approved
  12. Jigal van Hemert merged patch set 4 08/13/12, 06:55

  13. Mr. Jenkins commented on patch set 1 08/13/12, 06:55

  14. Mr. Jenkins commented on patch set 2 08/13/12, 06:55

  15. Mr. Jenkins commented on patch set 3 08/13/12, 06:55

  16. Mr. Jenkins commented on patch set 4 08/13/12, 06:55

  17. Wouter Wolters commented on patch set 4 08/13/12, 06:55

    (1 inline comment) Please have a look at the comment.

    class.t3lib_utility_math.php:184

    This is wrong. @param integer $value is correct. For all @param annotations this should be fixed. bool -> boolean
  18. Steffen Gebert commented on patch set 4 08/13/12, 06:55

    (1 inline comment)