13617[FEATURE] Add t3lib_utility_Math::isIntegerInRange
Commit message
Review
-
Code review CR +2
- Jigal van Hemert +2
- Christian Kuhn +1
-
Verified V +2
- Jigal van Hemert +2
- Christian Kuhn +1
Issues 1
Files 2
Review log 18
-
Christian Kuhn commented on patch set 1 08/13/12, 06:55
I would prefer that you didn't submit this No merge in this area without unit tests ;)class.t3lib_utility_mathTest.php:258This should be a data provider. -
Georg Ringer commented on patch set 1 08/13/12, 06:55
Verified; Looks good to me, but someone else must approve -
Steffen Gebert commented on patch set 1 08/13/12, 06:55
I would prefer that you didn't submit this Damn, added the tests to the wrong commit ;-) -
Steffen Gebert uploaded patch set 2 08/13/12, 06:55
-
Christian Kuhn commented on patch set 3 08/13/12, 06:55
(1 inline comment) -
Christian Kuhn commented on patch set 3 08/13/12, 06:55
will push update in some minutes. -
Christian Kuhn commented on patch set 4 08/13/12, 06:55
Verified; Looks good to me, but someone else must approve -
Christian Kuhn uploaded patch set 4 08/13/12, 06:55
-
Steffen Gebert uploaded patch set 3 08/13/12, 06:55
-
Jigal van Hemert commented on patch set 3 08/13/12, 06:55
Verified; Looks good to me, but someone else must approve -
Jigal van Hemert commented on patch set 4 V 0 08/13/12, 06:55
by team member; Looks good to me, approved -
Jigal van Hemert merged patch set 4 08/13/12, 06:55
-
Mr. Jenkins commented on patch set 1 08/13/12, 06:55
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/5227/ : SUCCESS -
Mr. Jenkins commented on patch set 2 08/13/12, 06:55
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/5229/ : SUCCESS -
Mr. Jenkins commented on patch set 3 08/13/12, 06:55
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/5230/ : SUCCESS -
Mr. Jenkins commented on patch set 4 08/13/12, 06:55
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/5232/ : SUCCESS -
Wouter Wolters commented on patch set 4 08/13/12, 06:55
(1 inline comment) Please have a look at the comment.class.t3lib_utility_math.php:184This is wrong. @param integer $value is correct. For all @param annotations this should be fixed. bool -> boolean -
Steffen Gebert commented on patch set 4 08/13/12, 06:55
(1 inline comment)