1363[TASK] Add version 4.5 CSS Styled Content Templates and Compat Version
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Ernesto Baschny +1
-
Verified V +2
- Christian Kuhn +2
- Ernesto Baschny +1
Issues 1
Files 6
- typo3/sysext/css_styled_content/static/v4.5/constants.txtnew+137 −0
- typo3/sysext/css_styled_content/static/v4.5/setup.txtnew+1834 −0
- typo3/sysext/css_styled_content/ext_localconf.php+1 −0
- typo3/sysext/css_styled_content/ext_tables.php1+1 −0
- typo3/sysext/install/updates/class.tx_coreupdates_compatversion.php1+2 −1
- typo3/sysext/install/updates/class.tx_coreupdates_cscsplit.php+6 −1
Review log 7
-
Ernesto Baschny commented on patch set 1 04/12/11, 22:00
I would prefer that you didn't submit this See inline comments. Will push a new diff right awayext_tables.php:16Must he static/v4.5 hereclass.tx_coreupdates_compatversion.php:133I guess we agreed on a "comma" at the end of such arrays, so that adding a new line won't cause the previous one to be modified too. -
Ernesto Baschny uploaded patch set 2 04/12/11, 22:00
-
Ernesto Baschny commented on patch set 2 04/12/11, 22:00
Verified; Looks good to me, but someone else must approve -
Mr. Jenkins commented on patch set 1 04/12/11, 22:00
Build Successful SUCCESS: http://ci.typo3.org/job/typo3-v4-core-gerrit/152/ -
Mr. Jenkins commented on patch set 2 04/12/11, 22:00
Build Successful SUCCESS: http://ci.typo3.org/job/typo3-v4-core-gerrit/185/ -
Christian Kuhn commented on patch set 2 V 0 04/12/11, 22:00
by team member; Looks good to me, approved Usual major release task. Looks good to me. -
Christian Kuhn merged patch set 2 04/12/11, 22:00