Review main Merged

1363[TASK] Add version 4.5 CSS Styled Content Templates and Compat Version

Susi Moog CR +2 V +2 Expert +1981 −2 updated 06/03/13, 20:49

Commit message

For changes to CSS Styled Content in TYPO3 version 4.6 we need new
static templates and a compatibility version.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Ernesto Baschny +1
  • Verified V +2
    • Christian Kuhn +2
    • Ernesto Baschny +1

Issues 1

Files 6

Review log 7

  1. Ernesto Baschny commented on patch set 1 04/12/11, 22:00

    I would prefer that you didn't submit this See inline comments. Will push a new diff right away

    ext_tables.php:16

    Must he static/v4.5 here

    class.tx_coreupdates_compatversion.php:133

    I guess we agreed on a "comma" at the end of such arrays, so that adding a new line won't cause the previous one to be modified too.
  2. Ernesto Baschny uploaded patch set 2 04/12/11, 22:00

  3. Ernesto Baschny commented on patch set 2 04/12/11, 22:00

    Verified; Looks good to me, but someone else must approve
  4. Mr. Jenkins commented on patch set 1 04/12/11, 22:00

  5. Mr. Jenkins commented on patch set 2 04/12/11, 22:00

  6. Christian Kuhn commented on patch set 2 V 0 04/12/11, 22:00

    by team member; Looks good to me, approved Usual major release task. Looks good to me.
  7. Christian Kuhn merged patch set 2 04/12/11, 22:00