Review main Merged

1366[FEATURE] Add helpful error messages in case of shortcut misconfiguration

Steffen Gebert CR +2 V +2 Easy +30 −2 updated 06/03/13, 20:49

Commit message

This change improves the output of wrongly misconfigured shortcut pages with
helpful error messages. Instead of "The requested page didn't have a proper
connection to the tree-root!", hints are given dependent on the configured
shortcut mode and target.

Thanks to Volker Graubaum (e-netconsulting) for sponsoring this fix with 80 beers
during the Bug Auction at T3BOARD11.

Review

  • Code review CR +2
    • Susi Moog +2
    • Helmut Hummel +1
  • Verified V +2
    • Susi Moog +2
    • Helmut Hummel +1

Issues 1

Files 1

Review log 12

  1. Helmut Hummel commented on patch set 1 04/01/11, 08:05

    Verified; Looks good to me, but someone else must approve Looks good, thanks
  2. Susi Moog commented on patch set 2 04/01/11, 08:05

    Verified; Looks good to me, but someone else must approve
  3. Helmut Hummel uploaded patch set 3 04/01/11, 08:05

  4. Susi Moog commented on patch set 4 V 0 04/01/11, 08:05

    by team member; Looks good to me, approved
  5. Helmut Hummel commented on patch set 4 04/01/11, 08:05

    Verified; Looks good to me, but someone else must approve Sorry for pushing a wrong patch. Fixed it with patch set 4
  6. Helmut Hummel uploaded patch set 4 04/01/11, 08:05

  7. Steffen Gebert uploaded patch set 2 04/01/11, 08:05

  8. Mr. Jenkins commented on patch set 1 04/01/11, 08:05

  9. Mr. Jenkins commented on patch set 2 04/01/11, 08:05

  10. Mr. Jenkins commented on patch set 3 04/01/11, 08:05

  11. Mr. Jenkins commented on patch set 4 04/01/11, 08:05

  12. Susi Moog merged patch set 4 04/01/11, 08:05