Review TYPO3_4-7 Merged

13757[SECURITY] Untrusted GP data is unserialized in old CSH handling

Oliver Hader CR +2 V +2 Easy +1 −1 updated 06/03/13, 20:49

Commit message

Using the old and already deprecated CSH handling in TYPO3 backend,
untrusted GP data is unserialized. There's no longer a code path
in TYPO3 to generate the GP data. So we can safely throw an exception
for requests with potential dangerous parameter values.

Review

  • Code review CR +2
    • Oliver Hader +2
  • Verified V +2
    • Oliver Hader +2

Files 1

Review log 2

  1. Oliver Hader commented on patch set 1 V 0 08/15/12, 10:19

    by team member; Looks good to me, approved Auto-approved
  2. Oliver Hader merged patch set 1 08/15/12, 10:19