13789[BUGFIX] File upload button is collapsed in Chrome 21
Commit message
Review
-
Code review CR +2
- Steffen Ritter +2
- Stefan Neufeind +1
- Oliver Klee +1
- Torben Hansen +1
- Marcel Küpper +1
- Marcus Schwemer +1
- Thomas Scheibitz +1
- Laurent Cherpit +1
-
Verified V +2
- Steffen Ritter +2
- Torben Hansen +1
- Marcel Küpper +1
- Thomas Scheibitz +1
- Laurent Cherpit +1
Issues 1
Files 1
Review log 19
-
Torben Hansen commented on patch set 1 09/07/12, 12:12
Verified; Looks good to me, but someone else must approve -
Steffen Gebert commented on patch set 1 09/07/12, 12:12
Please keep my comments in #39659 in mind: For master branch, there's even another problem that makes the uploader not working (at least for me in Chrome 21/22 on Mac OS). This change precedes this other fix and is especially necessary for 4.5-4.7. -
Steffen Gebert uploaded patch set 2 09/07/12, 12:12
-
Torben Hansen commented on patch set 3 09/07/12, 12:12
Verified; Looks good to me, but someone else must approve -
Torben Hansen commented on patch set 3 09/07/12, 12:12
Tested on Windows 7 (64-Bit) - FireFox 14.0.1 - Chrome 21.0.1180.83m - Opera 12.01 - Safari 5.1.7 (7534.57.2) -
Stefan Neufeind commented on patch set 3 09/07/12, 12:12
Looks good to me, but someone else must approve Fine by reading, didn't test though. But the changes don't seem to "intrusive". -
Marcus Schwemer commented on patch set 3 09/07/12, 12:12
Looks good to me, but someone else must approve -
Oliver Klee commented on patch set 3 09/07/12, 12:12
Looks good to me, but someone else must approve -
Steffen Gebert uploaded patch set 3 09/07/12, 12:12
-
Steffen Gebert commented on patch set 3 09/07/12, 12:12
Would you mind reporting, in which browsers you've tested this change? Thanks a lot! -
Steffen Ritter commented on patch set 3 V 0 09/07/12, 12:12
by team member; Looks good to me, approved -
Thomas Scheibitz commented on patch set 1 09/07/12, 12:12
I would prefer that you didn't submit this i think this works better: .swfupload { display: block; height: 25px; position: absolute; z-index: 2000; top: 2px; left: 3px; width: 90px; } This code set the Button in the right position and give it the correct size. -
Thomas Scheibitz commented on patch set 3 09/07/12, 12:12
Verified; Looks good to me, but someone else must approve -
Thomas Scheibitz commented on patch set 3 09/07/12, 12:12
I've tested it in Firefox 14.0.1 , Chrome 21.0.1180.82, Safari Version 6.0 (8536.25) and Internet Explorer 9 -
Laurent Cherpit commented on patch set 3 09/07/12, 12:12
Verified; Looks good to me, but someone else must approve Tx! -
Marcel Küpper commented on patch set 3 09/07/12, 12:12
Verified; Looks good to me, but someone else must approve -
Mr. Jenkins commented on patch set 1 09/07/12, 12:12
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/5271/ : SUCCESS -
Mr. Jenkins commented on patch set 3 09/07/12, 12:12
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/5411/ : SUCCESS -
Steffen Ritter merged patch set 3 09/07/12, 12:12