Review main Merged

13808[BUGFIX] Pagetree - Prevent a call to moveNode while creating nodes

Tobias Schultheiss CR +2 V +2 Easy +6 −2 updated 06/03/13, 20:49

Commit message

Review

  • Code review CR +2
    • Stefan Galinski +2
    • Wouter Wolters +1
  • Verified V +2
    • Stefan Galinski +2
    • Wouter Wolters +1

Files 1

Review log 19

  1. Georg Ringer commented on patch set 1 09/27/12, 20:58

    I would prefer that you didn't submit this please remove the pointers to the submodules from the commit
  2. Mr. Jenkins commented on patch set 1 09/27/12, 20:58

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/5284/ : FAILURE
  3. Mr. Jenkins commented on patch set 2 09/27/12, 20:58

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/5395/ : FAILURE
  4. Tobias Schultheiss uploaded patch set 2 09/27/12, 20:58

  5. Steffen Gebert uploaded patch set 4 09/27/12, 20:58

  6. Steffen Gebert commented on patch set 5 09/27/12, 20:58

    Hi Tobias, thanks for pushing this patch! Shouldn't also a non-strict comparison work? Steffen
  7. Steffen Gebert uploaded patch set 5 09/27/12, 20:58

  8. Stefan Galinski uploaded patch set 7 09/27/12, 20:58

  9. Stefan Galinski commented on patch set 7 09/27/12, 20:58

    Verified; Looks good to me, but someone else must approve
  10. Steffen Gebert uploaded patch set 6 09/27/12, 20:58

  11. Mr. Jenkins commented on patch set 3 09/27/12, 20:58

  12. Mr. Jenkins commented on patch set 5 09/27/12, 20:58

  13. Mr. Jenkins commented on patch set 6 09/27/12, 20:58

  14. Mr. Jenkins commented on patch set 7 09/27/12, 20:58

  15. Wouter Wolters commented on patch set 6 09/27/12, 20:58

    Looks good to me, but someone else must approve Looks like a no-brainer
  16. Wouter Wolters commented on patch set 7 09/27/12, 20:58

    Verified; Looks good to me, but someone else must approve
  17. Tobias Schultheiss uploaded patch set 3 09/27/12, 20:58

  18. Stefan Galinski commented on patch set 7 V 0 09/27/12, 20:58

    by team member; Looks good to me, approved
  19. Stefan Galinski merged patch set 7 09/27/12, 20:58