Review main Merged

13813[TASK] Add sys_notes to info module again

Georg Ringer CR +2 V +2 Normal +60 −11 updated 06/03/13, 20:49

Commit message

Once sys_note records have been shown in the info module but
after changing the code, this didn't work anymore.

This patch adds a hook which is then used by sys_note

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Wouter Wolters +1
    • Felix Kopp +1
  • Verified V +2
    • Christian Kuhn +2
    • Felix Kopp +1

Issues 1

Files 3

Review log 7

  1. Georg Ringer commented on patch set 1 08/18/12, 10:16

    yes, i just replaced the old non-working code
  2. Felix Kopp commented on patch set 1 08/18/12, 10:16

    Looks good to me, but someone else must approve Are the notes only coming up in page tree overview?
  3. Felix Kopp voted on patch set 1 V 0 08/18/12, 10:16

  4. Mr. Jenkins commented on patch set 1 08/18/12, 10:16

  5. Wouter Wolters commented on patch set 1 08/18/12, 10:16

    Looks good to me, but someone else must approve
  6. Christian Kuhn commented on patch set 1 V 0 08/18/12, 10:16

    by team member; Looks good to me, approved
  7. Christian Kuhn merged patch set 1 08/18/12, 10:16