13900[TASK] Update Swiftmailer to 4.2.1
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 161
- typo3/contrib/swiftmailer/classes/Swift/ByteStream/AbstractFilterableInputStream.php+133 −144
- typo3/contrib/swiftmailer/classes/Swift/ByteStream/ArrayByteStream.php+138 −156
- typo3/contrib/swiftmailer/classes/Swift/ByteStream/FileByteStream.php+169 −190
- typo3/contrib/swiftmailer/classes/Swift/CharacterReader/GenericFixedWidthReader.php+66 −72
- typo3/contrib/swiftmailer/classes/Swift/CharacterReader/UsAsciiReader.php+51 −58
- typo3/contrib/swiftmailer/classes/Swift/CharacterReader/Utf8Reader.php+147 −158
- typo3/contrib/swiftmailer/classes/Swift/CharacterReaderFactory/SimpleCharacterReaderFactory.php+102 −97
- typo3/contrib/swiftmailer/classes/Swift/CharacterStream/ArrayCharacterStream.php+241 −274
- typo3/contrib/swiftmailer/classes/Swift/CharacterStream/NgCharacterStream.php+245 −260
- typo3/contrib/swiftmailer/classes/Swift/Encoder/Base64Encoder.php+33 −39
- typo3/contrib/swiftmailer/classes/Swift/Encoder/QpEncoder.php+237 −220
- typo3/contrib/swiftmailer/classes/Swift/Encoder/Rfc2231Encoder.php+56 −62
- typo3/contrib/swiftmailer/classes/Swift/Events/CommandEvent.php+43 −47
- typo3/contrib/swiftmailer/classes/Swift/Events/CommandListener.php+5 −8
- typo3/contrib/swiftmailer/classes/Swift/Events/Event.php+18 −20
- typo3/contrib/swiftmailer/classes/Swift/Events/EventDispatcher.php+53 −60
- typo3/contrib/swiftmailer/classes/Swift/Events/EventListener.php+1 −1
- typo3/contrib/swiftmailer/classes/Swift/Events/EventObject.php+42 −45
- typo3/contrib/swiftmailer/classes/Swift/Events/ResponseEvent.php+44 −46
- typo3/contrib/swiftmailer/classes/Swift/Events/ResponseListener.php+5 −8
Show 141 more files
- typo3/contrib/swiftmailer/classes/Swift/Events/SendEvent.php+97 −107
- typo3/contrib/swiftmailer/classes/Swift/Events/SendListener.php+11 −14
- typo3/contrib/swiftmailer/classes/Swift/Events/SimpleEventDispatcher.php+131 −142
- typo3/contrib/swiftmailer/classes/Swift/Events/TransportChangeEvent.php+9 −12
- typo3/contrib/swiftmailer/classes/Swift/Events/TransportChangeListener.php+29 −32
- typo3/contrib/swiftmailer/classes/Swift/Events/TransportExceptionEvent.php+25 −29
- typo3/contrib/swiftmailer/classes/Swift/Events/TransportExceptionListener.php+6 −10
- typo3/contrib/swiftmailer/classes/Swift/KeyCache/ArrayKeyCache.php+161 −172
- typo3/contrib/swiftmailer/classes/Swift/KeyCache/DiskKeyCache.php+252 −278
- typo3/contrib/swiftmailer/classes/Swift/KeyCache/DummyKeyCache.php+88 −86
- typo3/contrib/swiftmailer/classes/Swift/KeyCache/KeyCacheInputStream.php+29 −32
- typo3/contrib/swiftmailer/classes/Swift/KeyCache/NullKeyCache.php+82 −87
- typo3/contrib/swiftmailer/classes/Swift/KeyCache/SimpleKeyCacheInputStream.php+101 −107
- typo3/contrib/swiftmailer/classes/Swift/Mailer/ArrayRecipientIterator.php+36 −40
- typo3/contrib/swiftmailer/classes/Swift/Mailer/RecipientIterator.php+13 −15
- typo3/contrib/swiftmailer/classes/Swift/Mime/ContentEncoder/Base64ContentEncoder.php+45 −56
- typo3/contrib/swiftmailer/classes/Swift/Mime/ContentEncoder/NativeQpContentEncoder.phpnew+58 −0
- typo3/contrib/swiftmailer/classes/Swift/Mime/ContentEncoder/PlainContentEncoder.php+136 −149
- typo3/contrib/swiftmailer/classes/Swift/Mime/ContentEncoder/QpContentEncoder.php+91 −88
- typo3/contrib/swiftmailer/classes/Swift/Mime/HeaderEncoder/Base64HeaderEncoder.php+34 −15
- typo3/contrib/swiftmailer/classes/Swift/Mime/HeaderEncoder/QpHeaderEncoder.php+38 −41
- typo3/contrib/swiftmailer/classes/Swift/Mime/Headers/AbstractHeader.php+426 −456
- typo3/contrib/swiftmailer/classes/Swift/Mime/Headers/DateHeader.php+90 −96
- typo3/contrib/swiftmailer/classes/Swift/Mime/Headers/IdentificationHeader.php+134 −140
- typo3/contrib/swiftmailer/classes/Swift/Mime/Headers/MailboxHeader.php+287 −286
- typo3/contrib/swiftmailer/classes/Swift/Mime/Headers/ParameterizedHeader.php+217 −238
- typo3/contrib/swiftmailer/classes/Swift/Mime/Headers/PathHeader.php+102 −111
- typo3/contrib/swiftmailer/classes/Swift/Mime/Headers/UnstructuredHeader.php+83 −87
- typo3/contrib/swiftmailer/classes/Swift/Mime/Attachment.php+116 −120
- typo3/contrib/swiftmailer/classes/Swift/Mime/CharsetObserver.php+5 −7
- typo3/contrib/swiftmailer/classes/Swift/Mime/ContentEncoder.php+14 −19
- typo3/contrib/swiftmailer/classes/Swift/Mime/EmbeddedFile.php+24 −29
- typo3/contrib/swiftmailer/classes/Swift/Mime/EncodingObserver.php+5 −8
- typo3/contrib/swiftmailer/classes/Swift/Mime/Grammar.php+147 −136
- typo3/contrib/swiftmailer/classes/Swift/Mime/Header.php+63 −65
- typo3/contrib/swiftmailer/classes/Swift/Mime/HeaderEncoder.php+5 −8
- typo3/contrib/swiftmailer/classes/Swift/Mime/HeaderFactory.php+48 −52
- typo3/contrib/swiftmailer/classes/Swift/Mime/HeaderSet.php+147 −150
- typo3/contrib/swiftmailer/classes/Swift/Mime/Message.php+207 −210
- typo3/contrib/swiftmailer/classes/Swift/Mime/MimeEntity.php+83 −87
- typo3/contrib/swiftmailer/classes/Swift/Mime/MimePart.php+184 −168
- typo3/contrib/swiftmailer/classes/Swift/Mime/ParameterizedHeader.php+12 −15
- typo3/contrib/swiftmailer/classes/Swift/Mime/SimpleHeaderFactory.php+142 −148
- typo3/contrib/swiftmailer/classes/Swift/Mime/SimpleHeaderSet.php+341 −359
- typo3/contrib/swiftmailer/classes/Swift/Mime/SimpleMessage.php+543 −554
- typo3/contrib/swiftmailer/classes/Swift/Mime/SimpleMimeEntity.php+771 −826
- typo3/contrib/swiftmailer/classes/Swift/Plugins/Decorator/Replacements.php+15 −17
- typo3/contrib/swiftmailer/classes/Swift/Plugins/Loggers/ArrayLogger.php+49 −52
- typo3/contrib/swiftmailer/classes/Swift/Plugins/Loggers/EchoLogger.php+36 −41
- typo3/contrib/swiftmailer/classes/Swift/Plugins/Pop/Pop3Connection.php+15 −17
- typo3/contrib/swiftmailer/classes/Swift/Plugins/Pop/Pop3Exception.php+11 −14
- typo3/contrib/swiftmailer/classes/Swift/Plugins/Reporters/HitReporter.php+36 −40
- typo3/contrib/swiftmailer/classes/Swift/Plugins/Reporters/HtmlReporter.php+18 −24
- typo3/contrib/swiftmailer/classes/Swift/Plugins/AntiFloodPlugin.php+110 −120
- typo3/contrib/swiftmailer/classes/Swift/Plugins/BandwidthMonitorPlugin.php+133 −142
- typo3/contrib/swiftmailer/classes/Swift/Plugins/DecoratorPlugin.php+173 −192
- typo3/contrib/swiftmailer/classes/Swift/Plugins/ImpersonatePlugin.php+14 −11
- typo3/contrib/swiftmailer/classes/Swift/Plugins/Logger.php+16 −18
- typo3/contrib/swiftmailer/classes/Swift/Plugins/LoggerPlugin.php+126 −132
- typo3/contrib/swiftmailer/classes/Swift/Plugins/MessageLogger.php+58 −59
- typo3/contrib/swiftmailer/classes/Swift/Plugins/PopBeforeSmtpPlugin.php+234 −249
- typo3/contrib/swiftmailer/classes/Swift/Plugins/RedirectingPlugin.php+78 −82
- typo3/contrib/swiftmailer/classes/Swift/Plugins/Reporter.php+13 −16
- typo3/contrib/swiftmailer/classes/Swift/Plugins/ReporterPlugin.php+48 −55
- typo3/contrib/swiftmailer/classes/Swift/Plugins/Sleeper.php+5 −7
- typo3/contrib/swiftmailer/classes/Swift/Plugins/ThrottlerPlugin.php+137 −152
- typo3/contrib/swiftmailer/classes/Swift/Plugins/Timer.php+5 −7
- typo3/contrib/swiftmailer/classes/Swift/StreamFilters/ByteArrayReplacementFilter.php+132 −156
- typo3/contrib/swiftmailer/classes/Swift/StreamFilters/StringReplacementFilter.php+41 −45
- typo3/contrib/swiftmailer/classes/Swift/StreamFilters/StringReplacementFilterFactory.php+25 −32
- typo3/contrib/swiftmailer/classes/Swift/Transport/Esmtp/Auth/CramMd5Authenticator.php+55 −63
- typo3/contrib/swiftmailer/classes/Swift/Transport/Esmtp/Auth/LoginAuthenticator.php+27 −33
- typo3/contrib/swiftmailer/classes/Swift/Transport/Esmtp/Auth/PlainAuthenticator.php+26 −32
- typo3/contrib/swiftmailer/classes/Swift/Transport/Esmtp/Authenticator.php+14 −18
- typo3/contrib/swiftmailer/classes/Swift/Transport/Esmtp/AuthHandler.php+224 −233
- typo3/contrib/swiftmailer/classes/Swift/Transport/AbstractSmtpTransport.php+420 −485
- typo3/contrib/swiftmailer/classes/Swift/Transport/EsmtpHandler.php+58 −62
- typo3/contrib/swiftmailer/classes/Swift/Transport/EsmtpTransport.php+332 −357
- typo3/contrib/swiftmailer/classes/Swift/Transport/FailoverTransport.php+60 −69
- typo3/contrib/swiftmailer/classes/Swift/Transport/IoBuffer.php+41 −45
- typo3/contrib/swiftmailer/classes/Swift/Transport/LoadBalancedTransport.php+138 −153
- typo3/contrib/swiftmailer/classes/Swift/Transport/MailInvoker.php+15 −17
- typo3/contrib/swiftmailer/classes/Swift/Transport/MailTransport.php+183 −201
- typo3/contrib/swiftmailer/classes/Swift/Transport/NullTransport.php+63 −66
- typo3/contrib/swiftmailer/classes/Swift/Transport/SendmailTransport.php+123 −140
- typo3/contrib/swiftmailer/classes/Swift/Transport/SimpleMailInvoker.php+23 −29
- typo3/contrib/swiftmailer/classes/Swift/Transport/SmtpAgent.php+15 −17
- typo3/contrib/swiftmailer/classes/Swift/Transport/SpoolTransport.php+90 −92
- typo3/contrib/swiftmailer/classes/Swift/Transport/StreamBuffer.php+268 −297
- typo3/contrib/swiftmailer/classes/Swift/Attachment.php+45 −51
- typo3/contrib/swiftmailer/classes/Swift/CharacterReader.php+37 −38
- typo3/contrib/swiftmailer/classes/Swift/CharacterReaderFactory.php+6 −9
- typo3/contrib/swiftmailer/classes/Swift/CharacterStream.php+56 −60
- typo3/contrib/swiftmailer/classes/Swift/ConfigurableSpool.php+41 −41
- typo3/contrib/swiftmailer/classes/Swift/DependencyContainer.php+295 −302
- typo3/contrib/swiftmailer/classes/Swift/DependencyException.php+8 −11
- typo3/contrib/swiftmailer/classes/Swift/EmbeddedFile.php+43 −49
- typo3/contrib/swiftmailer/classes/Swift/Encoder.php+8 −12
- typo3/contrib/swiftmailer/classes/Swift/Encoding.php+47 −50
- typo3/contrib/swiftmailer/classes/Swift/FailoverTransport.php+24 −27
- typo3/contrib/swiftmailer/classes/Swift/FileSpool.php+162 −180
- typo3/contrib/swiftmailer/classes/Swift/FileStream.php+5 −8
- typo3/contrib/swiftmailer/classes/Swift/Filterable.php+12 −15
- typo3/contrib/swiftmailer/classes/Swift/Image.php+37 −41
- typo3/contrib/swiftmailer/classes/Swift/InputByteStream.php+49 −51
- typo3/contrib/swiftmailer/classes/Swift/IoException.php+8 −11
- typo3/contrib/swiftmailer/classes/Swift/KeyCache.php+73 −78
- typo3/contrib/swiftmailer/classes/Swift/LoadBalancedTransport.php+24 −27
- typo3/contrib/swiftmailer/classes/Swift/Mailer.php+84 −91
- typo3/contrib/swiftmailer/classes/Swift/MailTransport.php+24 −27
- typo3/contrib/swiftmailer/classes/Swift/MemorySpool.phpnew+82 −0
- typo3/contrib/swiftmailer/classes/Swift/Message.php+54 −61
- typo3/contrib/swiftmailer/classes/Swift/MimePart.php+33 −40
- typo3/contrib/swiftmailer/classes/Swift/NullTransport.php+20 −20
- typo3/contrib/swiftmailer/classes/Swift/OutputByteStream.php+18 −20
- typo3/contrib/swiftmailer/classes/Swift/Preferences.php+72 −71
- typo3/contrib/swiftmailer/classes/Swift/ReplacementFilterFactory.php+7 −9
- typo3/contrib/swiftmailer/classes/Swift/RfcComplianceException.php+8 −11
- typo3/contrib/swiftmailer/classes/Swift/SendmailTransport.php+24 −27
- typo3/contrib/swiftmailer/classes/Swift/SmtpTransport.php+30 −35
- typo3/contrib/swiftmailer/classes/Swift/Spool.php+30 −28
- typo3/contrib/swiftmailer/classes/Swift/SpoolTransport.php+24 −24
- typo3/contrib/swiftmailer/classes/Swift/StreamFilter.php+13 −15
- typo3/contrib/swiftmailer/classes/Swift/SwiftException.php+8 −10
- typo3/contrib/swiftmailer/classes/Swift/Transport.php+35 −38
- typo3/contrib/swiftmailer/classes/Swift/TransportException.php+8 −11
- typo3/contrib/swiftmailer/classes/Swift/Validate.php+21 −21
- typo3/contrib/swiftmailer/classes/Swift.php+55 −43
- typo3/contrib/swiftmailer/dependency_maps/cache_deps.php+20 −22
- typo3/contrib/swiftmailer/dependency_maps/message_deps.php+5 −5
- typo3/contrib/swiftmailer/dependency_maps/mime_deps.php+103 −98
- typo3/contrib/swiftmailer/dependency_maps/transport_deps.php+65 −67
- typo3/contrib/swiftmailer/CHANGES+51 −1
- typo3/contrib/swiftmailer/LICENSE+0 −0
- typo3/contrib/swiftmailer/mime_types.php+58 −58
- typo3/contrib/swiftmailer/preferences.php+7 −8
- typo3/contrib/swiftmailer/README+2 −16
- typo3/contrib/swiftmailer/swift_init.php+3 −2
- typo3/contrib/swiftmailer/swift_required.php+11 −6
- typo3/contrib/swiftmailer/swift_required_pear.php+11 −6
- typo3/contrib/swiftmailer/VERSION+1 −1
Review log 8
-
Stefan Neufeind commented on patch set 1 11/26/12, 08:39
Straight replacement from 4.1.8 to 4.2.1. Directory-layout is still the same. I'd think we need a "verify" but can't really do a "code review" for this. On forge there has been some license-talk. An exception for TYPO3 was granted by the author for TYPO3 4.x. So to have it correct imho we'd need another exception for 6.x or even all future releases maybe. But that's imho not something that should prevent us from updating the lib itself. We should get a solution (exception-update?) for the license-thing before 6.0-release (final) imho. But imho that should be doable by emailing the author again (officially, maybe from association or core-team). -
Stefan Neufeind commented on patch set 1 11/26/12, 08:39
@Philipp: If we finally agree we can't ship 6.0 with Swiftmailer (because of no updated license-exception) we'd need to remove the library to do it correct. So for the moment I see no point in not at least updating it for now. There is a LICENSE.TYPO3v4-Exception in that contrib-directory - but for 4.x only (for now). Yes, somebody needs to take care of that. But it's out of scope for this task imho. -
Stefan Neufeind commented on patch set 1 11/26/12, 08:39
Philipp, please reconsider -
Philipp Gampe commented on patch set 1 11/26/12, 08:39
I would prefer that you didn't submit this Thanks for the patch, but what about the license issues mentioned in the issue? -
Philipp Gampe commented on patch set 1 11/26/12, 08:39
my -1 is not blocking. THE RM-Team must decide. Please get in touch with either Olli, Susanne or Christian. -
Andy Grunwald commented on patch set 1 11/26/12, 08:39
I would prefer that you didn't submit this Version 4.2.2 was released: http://blog.swiftmailer.org/post/34287975785/swiftmailer-4-2-2-released I prefer to update this one to 4.2.2 AND to clarify the license issue. -
Mr. Jenkins commented on patch set 1 11/26/12, 08:39
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/5343/ : SUCCESS -
Stefan Neufeind commented on patch set 1 11/26/12, 08:39
Abandoned New review submitted by Andy Grunwald at http://review.typo3.org/16738