Review main Merged

13918[BUGFIX] Wrong name attribute in custom user rendered items

Oliver Hader CR +2 V +2 Easy +8 −4 updated 06/03/13, 20:49

Commit message

Configuration items/properties that use a user function to
render the accordant values and possibilities (like, e.g.
saltedpasswords does in the Core) have a wrong name attribute.

The information to be delivered shall be:
* fieldName: Extbase prefixed form name
* fieldValue: the value of the field to be shown
* propertyName: Name of the property, e.g. "some.setting"

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Wouter Wolters +1
    • Susi Moog +1
  • Verified V +2
    • Christian Kuhn +2
    • Susi Moog +1

Files 2

Review log 9

  1. Susi Moog commented on patch set 2 08/20/12, 12:14

    Verified; Looks good to me, but someone else must approve
  2. Oliver Hader uploaded patch set 2 08/20/12, 12:14

  3. Oliver Hader commented on patch set 2 08/20/12, 12:14

    Renamed $fieldName to $propertyName... that's all
  4. Mr. Jenkins commented on patch set 1 08/20/12, 12:14

  5. Mr. Jenkins commented on patch set 2 08/20/12, 12:14

  6. Wouter Wolters commented on patch set 1 08/20/12, 12:14

    Looks good to me, but someone else must approve
  7. Wouter Wolters commented on patch set 2 08/20/12, 12:14

    Looks good to me, but someone else must approve
  8. Christian Kuhn commented on patch set 2 V 0 08/20/12, 12:14

    by team member; Looks good to me, approved
  9. Christian Kuhn merged patch set 2 08/20/12, 12:14