Review main Abandoned

13922[FEATURE] change external links to "real" external links in menu

Simon Schaufelberger CR 0 V 0 Easy +7 −4 updated 03/04/15, 03:55

Commit message

by default all links are rendered as internal links even if the page is an
external link. This patch changes the behavior so that external links get
rendered in the menu by default.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 18

  1. Ernesto Baschny commented on patch set 1 05/27/13, 17:19

    I would prefer that you didn't submit this While this looks ok, maybe this could be implemented (as I suggested in http://forge.typo3.org/issues/34863) for typoLink. Else you still will get "redirections" when editors link to the target page via RTE or linking of images etc. So to be consistent, this cannot only be implemented specifically for menus.
  2. Dmitry Dulepov commented on patch set 1 05/27/13, 17:19

    It would break statistics if anybody using AWStats or Apache logs to track external links as well. Not sure if it is good or bad, just thought it should be noted.
  3. Georg Ringer commented on patch set 1 05/27/13, 17:19

    I would prefer that you didn't submit this this needs to be configurable as sometimes this features is wanted like that, furthermore features can't go into 6.0 anymore, so please abandon this one and start with it when master = 6.1
    Releases: is missing
  4. Mr. Jenkins commented on patch set 1 05/27/13, 17:19

  5. Mathias Schreiber commented on patch set 1 12/07/14, 19:18

    Hey Simon, do you want to work on this any longer? Otherwise I'd offer to help out.
  6. Simon Schaufelberger commented on patch set 1 12/08/14, 11:21

    Mathias, you can go ahead. I have 1000 other things to do also ;)
  7. Mathias Schreiber wrote 12/14/14, 16:14

    Topic changed from 39938 to Typoscript
  8. Mathias Schreiber updated the commit message in patch set 2 12/20/14, 18:57

  9. Stefan Froemken uploaded patch set 3 12/21/14, 10:07

  10. Stefan Froemken commented on patch set 3 12/21/14, 10:10

    Now you can merge it again. But I don't like the patch very much. Why we have to call typoLink two times for external links?
  11. Stefan Froemken commented on patch set 3 CR +1 V +1 12/21/14, 10:24

    OK...we need the first call to get parameters like "target". The second call is for retrieving the external url.
  12. Anja Leichsenring updated the commit message in patch set 4 12/21/14, 15:17

  13. Anja Leichsenring commented on patch set 4 12/21/14, 15:17

    This is a feature and will not be backported.
  14. Anja Leichsenring commented on patch set 4 V -1 12/21/14, 15:26

    hm, as far as I can read, this patch does not connect with the requested feature anymore (configurable via TypoScript) and ignores Ernestos Remarks (fix it in the typolink function). Might be it creates a valid absolute URL for menu entries, but the description does not reflect this. Additionally, if this is a Feature or a breaking change, a documentation file is missing.
  15. Benni Mack commented on patch set 4 01/29/15, 18:49

    this feature is bad by design. THis means that you select a Page in the BE as external link, choose e.g. https:// and then make this work. I think you need to add a mailto: urlscheme and replace the occurences, but this does not work when calling the page directly (with ?id=...)
  16. Christian Kuhn voted on patch set 4 CR -1 03/03/15, 10:58

  17. Benni Mack abandoned the change 03/03/15, 10:58

    should be implemented differently
  18. Simon Schaufelberger commented on patch set 4 03/04/15, 03:55

    Benni: why not improve this change instead of abandoning it?