13952[FEATURE] Change the default doctype to html5
Commit message
Review
-
Code review CR +2
- Georg Ringer +2
-
Verified V +2
- Georg Ringer +2
Issues 1
Files 1
Review log 23
-
Gerrit wrote 11/05/12, 23:02
Your change could not be merged due to a path conflict. Please merge (or rebase) the change locally and upload the resolution for review. -
Michael Stucki commented on patch set 1 11/05/12, 23:02
Before this gets pushed, please take some minutes to fix the changelog message. We cannot fix it afterwards... -
Oliver Klee commented on patch set 1 11/05/12, 23:02
Looks good to me, but someone else must approve -
Michael Stucki commented on patch set 2 11/05/12, 23:02
I would prefer that you didn't submit this Did you read my comment? -
Michael Stucki commented on patch set 2 11/05/12, 23:02
< [FEATURE] make html5 default doctype > [FEATURE] Change the default doctype to html5 - Begin with upper-case letter - Use proper wording Sorry if that seems like nitpicking, but we cannot change those messages afterwards... -
Simon Schaufelberger commented on patch set 2 11/05/12, 23:02
yes, what do you mean with "fix" it? i added the release number now. what else do you want? -
Simon Schaufelberger commented on patch set 2 11/05/12, 23:02
i am not yet professional when it comes to perfect commit messages ;) sorry about that. -
Simon Schaufelberger uploaded patch set 2 11/05/12, 23:02
-
Michael Stucki commented on patch set 3 11/05/12, 23:02
Looks good to me, but someone else must approve You'll have to train hard for that... ;-) Thanks for the patch, it looks good to me now. -
Stefan Neufeind commented on patch set 3 11/05/12, 23:02
Looks good to me, but someone else must approve -
Stefan Neufeind commented on patch set 3 11/05/12, 23:02
Could somebody please have a look? Arguments aren't "we're after feature-freeze", are they? *sigh* -
Helmut Hummel commented on patch set 3 V 0 11/05/12, 23:02
by team member; Looks good to me, approved -
Georg Ringer uploaded patch set 4 11/05/12, 23:02
-
Georg Ringer commented on patch set 4 V 0 11/05/12, 23:02
by team member; Looks good to me, approved rebase -
Philipp Gampe commented on patch set 3 11/05/12, 23:02
Looks good to me, but someone else must approve -
Simon Schaufelberger uploaded patch set 3 11/05/12, 23:02
-
Simon Schaufelberger commented on patch set 3 11/05/12, 23:02
can somebody please submit that to 6.0 release? -
Mattias Nilsson commented on patch set 2 11/05/12, 23:02
Looks good to me, but someone else must approve -
Mr. Jenkins commented on patch set 1 11/05/12, 23:02
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/5379/ : SUCCESS -
Mr. Jenkins commented on patch set 2 11/05/12, 23:02
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/5381/ : SUCCESS -
Mr. Jenkins commented on patch set 3 11/05/12, 23:02
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/5382/ : SUCCESS -
Mr. Jenkins commented on patch set 4 11/05/12, 23:02
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/6565/ : SUCCESS -
Georg Ringer merged patch set 4 11/05/12, 23:02