Review main Merged

13952[FEATURE] Change the default doctype to html5

Simon Schaufelberger CR +2 V +2 Easy +6 −2 updated 06/03/13, 20:49

Commit message

Review

  • Code review CR +2
    • Georg Ringer +2
  • Verified V +2
    • Georg Ringer +2

Issues 1

Files 1

Review log 23

  1. Gerrit wrote 11/05/12, 23:02

    Your change could not be merged due to a path conflict. Please merge (or rebase) the change locally and upload the resolution for review.
  2. Michael Stucki commented on patch set 1 11/05/12, 23:02

    Before this gets pushed, please take some minutes to fix the changelog message. We cannot fix it afterwards...
  3. Oliver Klee commented on patch set 1 11/05/12, 23:02

    Looks good to me, but someone else must approve
  4. Michael Stucki commented on patch set 2 11/05/12, 23:02

    I would prefer that you didn't submit this Did you read my comment?
  5. Michael Stucki commented on patch set 2 11/05/12, 23:02

    < [FEATURE] make html5 default doctype > [FEATURE] Change the default doctype to html5 - Begin with upper-case letter - Use proper wording Sorry if that seems like nitpicking, but we cannot change those messages afterwards...
  6. Simon Schaufelberger commented on patch set 2 11/05/12, 23:02

    yes, what do you mean with "fix" it? i added the release number now. what else do you want?
  7. Simon Schaufelberger commented on patch set 2 11/05/12, 23:02

    i am not yet professional when it comes to perfect commit messages ;) sorry about that.
  8. Simon Schaufelberger uploaded patch set 2 11/05/12, 23:02

  9. Michael Stucki commented on patch set 3 11/05/12, 23:02

    Looks good to me, but someone else must approve You'll have to train hard for that... ;-) Thanks for the patch, it looks good to me now.
  10. Stefan Neufeind commented on patch set 3 11/05/12, 23:02

    Looks good to me, but someone else must approve
  11. Stefan Neufeind commented on patch set 3 11/05/12, 23:02

    Could somebody please have a look? Arguments aren't "we're after feature-freeze", are they? *sigh*
  12. Helmut Hummel commented on patch set 3 V 0 11/05/12, 23:02

    by team member; Looks good to me, approved
  13. Georg Ringer uploaded patch set 4 11/05/12, 23:02

  14. Georg Ringer commented on patch set 4 V 0 11/05/12, 23:02

    by team member; Looks good to me, approved rebase
  15. Philipp Gampe commented on patch set 3 11/05/12, 23:02

    Looks good to me, but someone else must approve
  16. Simon Schaufelberger uploaded patch set 3 11/05/12, 23:02

  17. Simon Schaufelberger commented on patch set 3 11/05/12, 23:02

    can somebody please submit that to 6.0 release?
  18. Mattias Nilsson commented on patch set 2 11/05/12, 23:02

    Looks good to me, but someone else must approve
  19. Mr. Jenkins commented on patch set 1 11/05/12, 23:02

  20. Mr. Jenkins commented on patch set 2 11/05/12, 23:02

  21. Mr. Jenkins commented on patch set 3 11/05/12, 23:02

  22. Mr. Jenkins commented on patch set 4 11/05/12, 23:02

  23. Georg Ringer merged patch set 4 11/05/12, 23:02