13969[FEATURE] stdWrap for string-padding (like PHP-function str_pad)
Commit message
Review
-
Code review CR +2
- Dmitry Dulepov +2
- Wouter Wolters +1
- Philipp Gampe +1
-
Verified V +2
- Dmitry Dulepov +2
- Wouter Wolters +1
- Philipp Gampe +1
Issues 1
Files 2
Review log 15
-
Dmitry Dulepov merged patch set 1 12/04/12, 11:16
-
Stefan Neufeind commented on patch set 1 12/04/12, 11:16
Could not yet test locally since some recent merge seems to have made a change so my local test-env currently denies work. But it's just a small feature. See if you like it. Test and doc will be added for sure, if you think it's okay to have in. I was stunned to see we have all cropping and trimming but no simple padding yet.6.1 -
Mr. Jenkins commented on patch set 1 12/04/12, 11:16
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/5392/ : SUCCESS -
Stefan Neufeind commented on patch set 2 12/04/12, 11:16
Looks good to me, but someone else must approve thanks Wouter for the testcase. Looks good to me, and it already helped finding a small glitch which you also fixed :-) -
Stefan Neufeind commented on patch set 2 12/04/12, 11:16
(1 inline comment) -
Mr. Jenkins commented on patch set 2 12/04/12, 11:16
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/5405/ : SUCCESS -
Wouter Wolters commented on patch set 2 12/04/12, 11:16
Verified; Looks good to me, but someone else must approve -
Wouter Wolters uploaded patch set 2 12/04/12, 11:16
-
Dmitry Dulepov commented on patch set 3 V 0 12/04/12, 11:16
by team member; Looks good to me, approved -
Philipp Gampe commented on patch set 3 12/04/12, 11:16
Looks good to me, but someone else must approve -
Philipp Gampe commented on patch set 3 V 0 12/04/12, 11:16
tested with unit test -
Mr. Jenkins commented on patch set 3 12/04/12, 11:16
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/6894/ : SUCCESS -
Wouter Wolters commented on patch set 3 12/04/12, 11:16
Verified; Looks good to me, but someone else must approve Rebased and changed commit message for 6.1 -
Wouter Wolters uploaded patch set 3 12/04/12, 11:16
-
Dmitry Dulepov commented on patch set 3 12/04/12, 11:16
Documentation change is submitted: http://forge.typo3.org/issues/43577