1397[BUGFIX] Throw HttpStatusExceptions in tslib_fe
Commit message
Review
-
Code review CR +2
- Steffen Gebert +2
- Georg Ringer +1
- Andreas Wolf +1
-
Verified V +2
- Steffen Gebert +2
- Georg Ringer +1
- Andreas Wolf +1
Issues 1
Files 1
Review log 27
Show 2 earlier messages
-
Ernesto Baschny commented on patch set 1 06/16/11, 05:31
Looks good to me, but someone else must approve Cool stuff. Haven't tested if yet, but it looks fine. Some last places are missing: 1) "The page is not configured" (Line 2083) 2) "No TypoScript template found" (Line 2143) which could also throw the PageNotFound Exception (because this is what's happening: There are no pages yet). -
Oliver Hader commented on patch set 1 06/16/11, 05:31
Looks good to me, but someone else must approve Looks good to me, however it would be great if you could take care of Ernesto's suggestion as well (I also consider those two places as 503).class.tslib_fe.php:1176Do we want to replace this as well by one of our HTTP exceptions?
-
Steffen Gebert commented on patch set 1 06/16/11, 05:31
Isn't that more a 500? It's a configuration error.. (like no DB credentials entered) -
Andreas Wolf uploaded patch set 3 06/16/11, 05:31
-
Andreas Wolf commented on patch set 3 06/16/11, 05:31
Looks good to me, but someone else must approve I changed the usage of a non-existing class to the existing one (which Steffen apparently meant to use) and added a new class for 500 errors (which is now used in one case). Did not verify this one as there are a lot of cases where exceptions are thrown. -
Andreas Wolf uploaded patch set 4 06/16/11, 05:31
-
Andreas Wolf commented on patch set 4 06/16/11, 05:31
Verified; Looks good to me, but someone else must approve I removed the doubled messages in some of the conditions; also tested all exceptions and found them to be working. Will push this one after another review. -
Andreas Wolf uploaded patch set 5 06/16/11, 05:31
-
Andreas Wolf commented on patch set 5 06/16/11, 05:31
I would prefer that you didn't submit this The commit message of course has to be adjusted... Forgot to remove the comment. Apart from that, this is ready for commit with one additional review. -
Andreas Wolf commented on patch set 5 06/16/11, 05:31
Verified; Looks good to me, but someone else must approve Steffen, you are indeed right. I just checked the difference between the two versions wrt to this exception and I didn't notice any relevant difference. So I removed the new exception again. Hope we can now agree on committing this ;-) -
Georg Ringer commented on patch set 2 06/16/11, 05:31
Verified; Looks good to me, but someone else must approve -
Georg Ringer voted on patch set 5 V 0 06/16/11, 05:31
-
Steffen Gebert commented on patch set 2 06/16/11, 05:31
*bump* P.S: Jenkins is wrong.. -
Steffen Gebert uploaded patch set 2 06/16/11, 05:31
-
Steffen Gebert commented on patch set 3 06/16/11, 05:31
An Internal Server Error is for me an uncaught exception.. So I don't see the need for an extra class (when do you throw an *Exception and when an InternalServerErrorException?) -
Andreas Wolf commented on patch set 6 06/16/11, 05:31
Verified; Looks good to me, but someone else must approve Renewing my +1 for v4 (without the new class stuff). -
Georg Ringer commented on patch set 6 06/16/11, 05:31
Verified; Looks good to me, but someone else must approve -
Steffen Gebert uploaded patch set 6 06/16/11, 05:31
-
Steffen Gebert commented on patch set 6 06/16/11, 05:31
Reverted the change to the Commit Message, so this should be the same as v4 -
Mr. Jenkins commented on patch set 1 06/16/11, 05:31
Build Successful SUCCESS: http://ci.typo3.org/job/typo3-v4-core-gerrit/188/ -
Mr. Jenkins commented on patch set 2 06/16/11, 05:31
Fails; I would prefer that you didn't submit this Build Failed http://ci.typo3.org/job/typo3-v4-core-gerrit/435/ : FAILURE -
Mr. Jenkins commented on patch set 3 06/16/11, 05:31
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/650/ : SUCCESS -
Mr. Jenkins commented on patch set 4 06/16/11, 05:31
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/651/ : SUCCESS -
Mr. Jenkins commented on patch set 5 06/16/11, 05:31
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/652/ : SUCCESS -
Mr. Jenkins commented on patch set 6 06/16/11, 05:31
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/680/ : SUCCESS -
Steffen Gebert commented on patch set 6 V 0 06/16/11, 05:31
by team member; Looks good to me, approved submitting -
Steffen Gebert merged patch set 6 06/16/11, 05:31