Review TYPO3_4-7 Merged

13980[BUGFIX] Fix warnings in em on tab Maintenance

Stefan Neufeind CR +2 V +2 Easy +3 −3 updated 06/03/13, 20:49

Commit message

One variable is used without checking if it is set and on the other
place an array key is used twice which is just a mistake of the coder.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Stefan Neufeind +1
    • Anja Leichsenring +1
  • Verified V +2
    • Christian Kuhn +2
    • Anja Leichsenring +1

Files 2

Review log 8

  1. Stefan Neufeind uploaded patch set 2 01/25/13, 22:43

  2. Stefan Neufeind commented on patch set 2 01/25/13, 22:43

    Originally planned for 6.0, but the EM was exchanged. So this is just 4.5 to 4.7. Original 6.0-review as at: https://review.typo3.org/13560
  3. Stefan Neufeind commented on patch set 2 01/25/13, 22:43

    Looks good to me, but someone else must approve Makes sense by reading. Matches description and looks quite obvious. Nice catch.
  4. Stefan Neufeind commented on patch set 2 01/25/13, 22:43

    *ping*
  5. Philipp Gampe commented on patch set 2 01/25/13, 22:43

    you may vote for this as this is my patch ;)
  6. Anja Leichsenring commented on patch set 2 01/25/13, 22:43

    Verified; Looks good to me, but someone else must approve
  7. Christian Kuhn commented on patch set 2 V 0 01/25/13, 22:43

    by team member; Looks good to me, approved
  8. Christian Kuhn merged patch set 3 01/25/13, 22:43